From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26376 invoked from network); 8 May 2002 15:46:01 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 8 May 2002 15:46:01 -0000 Received: (qmail 7608 invoked by alias); 8 May 2002 15:45:48 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 17097 Received: (qmail 7594 invoked from network); 8 May 2002 15:45:46 -0000 To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: PATCH: tcp close bug Date: Wed, 08 May 2002 16:45:15 +0100 Message-ID: <12729.1020872715@csr.com> From: Peter Stephenson The way the list of sessions is scanned when closing all tcp sessions (with `tcp -c' and no arguments, or when unlinking) is liable to crash the shell. Index: Src/Modules/tcp.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v retrieving revision 1.23 diff -u -r1.23 tcp.c --- Src/Modules/tcp.c 25 Apr 2002 14:06:47 -0000 1.23 +++ Src/Modules/tcp.c 8 May 2002 15:43:04 -0000 @@ -279,10 +279,12 @@ static void tcp_cleanup(void) { - LinkNode node; + LinkNode node, next; - for (node = firstnode(ztcp_sessions); node; incnode(node)) + for (node = firstnode(ztcp_sessions); node; node = next) { + next = node->next; tcp_close((Tcp_session)getdata(node)); + } } /**/ -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 392070 ********************************************************************** The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer. **********************************************************************