From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30949-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 15792 invoked by alias); 6 Jan 2013 18:43:47 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30949
Received: (qmail 22927 invoked from network); 6 Jan 2013 18:43:35 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <130106104317.ZM2414@torch.brasslantern.com>
Date: Sun, 06 Jan 2013 10:43:17 -0800
In-reply-to:
 <CAPzVZKkeEr_oHVkv-mpudxCN=k=sP4PyvyCTofi3+JaP=fJafw@mail.gmail.com>
Comments: In reply to Yaniv Aknin <yaniv@aknin.name>
 "read -q broken on OSX / BSD?" (Jan  6, 11:06am)
References: <CAPzVZKkeEr_oHVkv-mpudxCN=k=sP4PyvyCTofi3+JaP=fJafw@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: read -q broken on OSX / BSD?
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jan 6, 11:06am, Yaniv Aknin wrote:
} Subject: read -q broken on OSX / BSD?
}
} I'm running % read -q, and then typing a single character which
} isn't y, Y or n. However, the value set in $REPLY isn't n, it is the
} character I typed.

This is apparently version-dependent rather than platform-dependent.
It got changed by workers/27188 back in July 2009, but nobody noticed,
which pretty much tells you that read -q was mainly being used for its
exit status and not for what it returned.

Index: Src/builtin.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/builtin.c,v
retrieving revision 1.268
diff -u -r1.268 builtin.c
--- Src/builtin.c	8 Nov 2012 16:50:42 -0000	1.268
+++ Src/builtin.c	6 Jan 2013 18:40:37 -0000
@@ -5490,6 +5490,9 @@
 		eof = 2;
 	    else
 		eof = (bptr - buf != 1 || (buf[0] != 'y' && buf[0] != 'Y'));
+	    buf[0] = eof ? 'n' : 'y';
+	    buf[1] = 0;
+	    bptr = buf+2;
 	}
 	if (OPT_ISSET(ops,'e') || OPT_ISSET(ops,'E'))
 	    fwrite(buf, bptr - buf, 1, stdout);



-- 
Barton E. Schaefer