From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24364 invoked from network); 14 May 2002 17:45:10 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 14 May 2002 17:45:10 -0000 Received: (qmail 3499 invoked by alias); 14 May 2002 17:44:57 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 17162 Received: (qmail 3486 invoked from network); 14 May 2002 17:44:56 -0000 To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: PATCH: gethostbyaddr() argument in tcp.c Date: Tue, 14 May 2002 18:44:27 +0100 Message-ID: <13034.1021398267@csr.com> From: Peter Stephenson This one is entirely cosmetic. The latest POSIX/SUS/ISO specification says the first argument is `const void *', which wouldn't cause a warning; however, solaris uses `const char *', which does. Converting explicitly to `const void *' should keep everybody happy, I hope. Index: Src/Modules/tcp.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v retrieving revision 1.26 diff -u -r1.26 tcp.c --- Src/Modules/tcp.c 14 May 2002 17:29:53 -0000 1.26 +++ Src/Modules/tcp.c 14 May 2002 17:38:59 -0000 @@ -565,12 +565,12 @@ if (sess->fd != -1) { - zthost = gethostbyaddr(&(sess->sock.in.sin_addr), sizeof(struct sockaddr_in), AF_INET); + zthost = gethostbyaddr((const void *)&(sess->sock.in.sin_addr), sizeof(struct sockaddr_in), AF_INET); if (zthost) localname = zthost->h_name; else localname = ztrdup(inet_ntoa(sess->sock.in.sin_addr)); - ztpeer = gethostbyaddr(&(sess->peer.in.sin_addr), sizeof(struct sockaddr_in), AF_INET); + ztpeer = gethostbyaddr((const void *)&(sess->peer.in.sin_addr), sizeof(struct sockaddr_in), AF_INET); if (ztpeer) remotename = ztpeer->h_name; else -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 392070 ********************************************************************** The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer. **********************************************************************