From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: coredump on C-c
Date: Thu, 26 Sep 2013 21:20:36 -0700 [thread overview]
Message-ID: <130926212036.ZM29497@torch.brasslantern.com> (raw)
In-Reply-To: <130926204956.ZM23921@torch.brasslantern.com>
On Sep 26, 8:49pm, Bart Schaefer wrote:
}
} For example, there may be a performance hit for queuing signals around
} all the hash table traversals in the add* and scan* functions. If we
} assume restartable syscalls that's probably OK for scan
By "that's" I mean "NOT queuing signals there is" in case that wasn't
clear.
It occurs to me, though, that queuing signals all over hashtable.c may
be an over-reaction. Maybe the problem is just with re-entering the
endparamscope() routine, and that's where queue_signals() is needed.
Which is a much smaller change, and probably harmless even if it does
not help:
diff --git a/Src/params.c b/Src/params.c
index 8649178..d6711e4 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -4667,10 +4667,12 @@ startparamscope(void)
mod_export void
endparamscope(void)
{
+ queue_signals();
locallevel--;
/* This pops anything from a higher locallevel */
saveandpophiststack(0, HFILE_USE_OPTIONS);
scanhashtable(paramtab, 0, 0, 0, scanendscope, 0);
+ unqueue_signals();
}
/**/
next prev parent reply other threads:[~2013-09-27 4:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 17:52 Eitan Adler
2013-09-26 21:31 ` Bart Schaefer
2013-09-27 1:10 ` Eitan Adler
2013-09-27 3:49 ` Bart Schaefer
2013-09-27 4:20 ` Bart Schaefer [this message]
2013-09-27 15:50 ` Peter Stephenson
2013-09-27 19:50 ` Bart Schaefer
2013-09-27 5:00 ` Eitan Adler
2013-10-16 21:40 ` Eitan Adler
2013-10-17 0:04 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130926212036.ZM29497@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).