From: Bart Schaefer <schaefer@brasslantern.com>
To: luc <luc.lists@gmail.com>, zsh-workers@zsh.org
Subject: Re: Bug in completion for make
Date: Fri, 18 Oct 2013 08:32:42 -0700 [thread overview]
Message-ID: <131018083242.ZM8579@torch.brasslantern.com> (raw)
In-Reply-To: <20131018144022.GA61854@mbp.Speedport_W_700V>
On Oct 18, 4:40pm, luc wrote:
}
} The pattern used in _make-parseMakefile (in case ...
} esac) is ([[:alnum:]][^$TAB:=]#:[^=]*) . I do not understand why this
} matches a line starting with a TAB-character.
It's not the pattern that's the problem, it's the use of the "read"
builtin, which is stripping off the leading tab because a tab is in
the default value of $IFS.
We've had this come up elsewhere in completion functions.
diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make
index 7b4c224..e5a513f 100644
--- a/Completion/Unix/Command/_make
+++ b/Completion/Unix/Command/_make
@@ -59,7 +59,7 @@ _make-expandVars() {
}
_make-parseMakefile () {
- local input var val target dep TAB=$'\t' dir=$1 tmp
+ local input var val target dep TAB=$'\t' dir=$1 tmp IFS=
while read input
do
prev parent reply other threads:[~2013-10-18 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 14:40 luc
2013-10-18 15:32 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131018083242.ZM8579@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=luc.lists@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).