zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Axel Beckert <abe@deuxchevaux.org>, zsh-workers@zsh.org
Subject: Re: Test suite failures in 5.0.2-test-1 _and_ 5.0.2-test-3 on automatic build (was: Re: 5.0.2-test-2 is available)
Date: Mon, 02 Dec 2013 09:22:15 -0800	[thread overview]
Message-ID: <131202092215.ZM21914@torch.brasslantern.com> (raw)
In-Reply-To: <20131202162830.GT13790@sym.noone.org>

On Dec 2,  5:28pm, Axel Beckert wrote:
}
} *** /tmp/zsh.ztst.err.16395	Mon Dec  2 16:15:29 2013
} --- /tmp/zsh.ztst.terr.16395	Mon Dec  2 16:15:29 2013
} ***************
} *** 0 ****
} --- 1 ----
} + (eval):setopt:1: can't change option: MONITOR

This is a tough one to reproduce because I can't manually create a case
where the MONITOR option can't be reset.

However, changing the option is non-critical to the test itself, so it's
only necessary to suppress the extra stderr output.

Attempting to test this did reveal that acquire_pgrp() can still be caused
to go into an infinite loop, even after the patch in 31906, if the shell
that is attempting to assert MONITOR is sufficiently far down the process
tree from the parent that actually controls the terminal.  I guess that
loop just needs to give up after a certain number of failed attempts, if
it really needs to be a loop at all.  (No patch for that yet.)

diff --git a/Test/A05execution.ztst b/Test/A05execution.ztst
index ba7e02c..61f6f5a 100644
--- a/Test/A05execution.ztst
+++ b/Test/A05execution.ztst
@@ -179,7 +179,7 @@
 0:Status reset by starting a backgrounded command
 >0
 
-  setopt MONITOR
+  { setopt MONITOR } 2>/dev/null
   [[ -o MONITOR ]] || print -u $ZTST_fd 'Unable to change MONITOR option'
   repeat 2048; do (return 2 |
                    return 1 |


  reply	other threads:[~2013-12-02 17:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131201194653.7a98a4a4@pws-pc.ntlworld.com>
     [not found] ` <20131202151557.1636@binki>
2013-12-02 16:08   ` 5.0.2-test-2 is available Peter Stephenson
2013-12-02 16:36     ` Bart Schaefer
2013-12-02 16:51       ` Peter Stephenson
2013-12-02 17:31         ` Bart Schaefer
2013-12-02 17:40           ` Peter Stephenson
2013-12-08 20:22         ` Peter Stephenson
2013-12-08 21:36           ` Bart Schaefer
2013-12-10  3:21           ` 5.0.2-test-3, arithmetic on pointer to void pda
2013-12-10  6:27             ` Bart Schaefer
2013-12-02 18:08       ` 5.0.2-test-2 is available Bart Schaefer
     [not found] ` <20131202155119.GR13790@sym.noone.org>
     [not found]   ` <20131202160133.7d77d7be@pwslap01u.europe.root.pri>
2013-12-02 16:16     ` Test suite failures on static build (was: 5.0.2-test-2 is available) Axel Beckert
2013-12-02 16:28       ` Peter Stephenson
2013-12-02 16:43       ` Bart Schaefer
2013-12-02 16:48         ` Axel Beckert
2013-12-02 16:57           ` [seems solved] " Axel Beckert
2013-12-02 17:20             ` One test suite failure left on static build (after $HOME has been fixed) Axel Beckert
2013-12-02 17:49               ` Bart Schaefer
     [not found] ` <20131202151502.GP13790@sym.noone.org>
2013-12-02 16:28   ` Test suite failures in 5.0.2-test-1 _and_ 5.0.2-test-3 on automatic build (was: Re: 5.0.2-test-2 is available) Axel Beckert
2013-12-02 17:22     ` Bart Schaefer [this message]
2013-12-02 18:25       ` Axel Beckert
2013-12-02 18:29         ` Bart Schaefer
2013-12-02 18:34         ` Bart Schaefer
2013-12-03  8:15           ` [SOLVED] " Axel Beckert
     [not found] ` <CAJ1KOAj6_KJL59OM_03JhzFLzSJvw_-N8zAeiv94kh7PpNdN0Q@mail.gmail.com>
     [not found]   ` <CAJ1KOAjJumPnzGWT+sg6-A34Aisp_+PfaCZkP3P8-LDpM7YJhg@mail.gmail.com>
2013-12-09 10:12     ` 5.0.2-test-2 is available Peter Stephenson
2013-12-09 10:16       ` İsmail Dönmez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=131202092215.ZM21914@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=abe@deuxchevaux.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).