From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35243-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 5665 invoked by alias); 20 May 2015 17:58:12 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35243
Received: (qmail 947 invoked from network); 20 May 2015 17:58:09 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham
	autolearn_force=no version=3.4.0
From: Kamil Dudka <kdudka@redhat.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
Date: Wed, 20 May 2015 19:35:13 +0200
Message-ID: <13142758.yMuWt9XIhO@kdudka.brq.redhat.com>
User-Agent: KMail/4.14.7 (Linux/4.0.1-300.fc22.x86_64; KDE/4.14.7; x86_64; ; )
In-Reply-To: <150520102300.ZM26712@torch.brasslantern.com>
References: <1432059854-2109-1-git-send-email-kdudka@redhat.com> <4003127.y1UWooicOC@kdudka.brq.redhat.com> <150520102300.ZM26712@torch.brasslantern.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23

On Wednesday 20 May 2015 10:23:00 Bart Schaefer wrote:
> On May 20,  4:43pm, Kamil Dudka wrote:
> }
> } Good catch!  Then your patch certainly looks as a better choice to me.
> 
> It belatedly occurs to me that adding
> 
>     if (!value)
> 	value = "";
> 
> would have been a sufficient change.  Oh, well.

I am quite new to zsh code but this drives me to a question: Are the strings 
allocated in mkenvstr() freed anywhere?

Kamil