From: Zefram <zefram@dcs.warwick.ac.uk>
To: zsh-workers@math.gatech.edu
Subject: suffix removal again
Date: Sat, 22 Mar 1997 16:36:46 GMT [thread overview]
Message-ID: <13329.199703221636@stone.dcs.warwick.ac.uk> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Even after my previous two patches on the subject, there is still one
remaining bug in suffix removal, that has taken me a while to reproduce.
The symptom is that when menu completing parameter names (after a $),
inserting space or a character such as `:' (that must go immediately
after the parameter name) causes the last character of the parameter
name to be deleted. What is happening is that zsh is attempting to
delete the space it added following the parameter name, not realising
that it already deleted that for the purpose of menu completion.
This patch must be applied on top of the others. If anyone notices any
further problems in this area, please let me know.
-zefram
*** Src/Zle/zle_main.c 1997/03/19 15:47:09 1.27
--- Src/Zle/zle_main.c 1997/03/21 23:52:51
***************
*** 513,521 ****
{
if(addedsuffix) {
backdel(addedsuffix);
! addedsuffix = complexpect = 0;
invalidatelist();
}
}
/* initialise command modifiers */
--- 513,522 ----
{
if(addedsuffix) {
backdel(addedsuffix);
! addedsuffix = 0;
invalidatelist();
}
+ complexpect = 0;
}
/* initialise command modifiers */
*** Src/Zle/zle_tricky.c 1997/03/18 23:56:50 1.23
--- Src/Zle/zle_tricky.c 1997/03/21 23:49:03
***************
*** 3328,3333 ****
--- 3328,3334 ----
backdel(1);
if (ccs != inscs)
cs = ccs;
+ addedsuffix--;
} else
cs--;
}
-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: ascii
iQCVAwUBMzMh8HD/+HJTpU/hAQEHvwQAoEvzpuXxVKoX2JiudINQ4fmfOJPoZWQB
2SjbxOJf5vvRO1s5S1FFlvggcP8V5yJ1YEVtFDUuCTzyzclVZrLEjcAxv5hJ+9SG
g27GBpmIiXJUf8hHripE+WAjU59kNjsRB+heMmzhtcj4czlhll8ha/nm1UR6v3Br
K0+TdROUr5U=
=9jtV
-----END PGP SIGNATURE-----
reply other threads:[~1997-03-22 16:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13329.199703221636@stone.dcs.warwick.ac.uk \
--to=zefram@dcs.warwick.ac.uk \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).