From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1619 invoked from network); 27 Jul 2004 23:53:42 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 27 Jul 2004 23:53:42 -0000 Received: (qmail 15263 invoked from network); 27 Jul 2004 23:53:37 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 27 Jul 2004 23:53:37 -0000 Received: (qmail 24001 invoked by alias); 27 Jul 2004 23:52:56 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20207 Received: (qmail 23980 invoked from network); 27 Jul 2004 23:52:55 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by 130.225.247.90 with SMTP; 27 Jul 2004 23:52:55 -0000 Received: (qmail 22377 invoked from network); 27 Jul 2004 22:48:27 -0000 Received: from mail36.messagelabs.com (193.109.254.211) by a.mx.sunsite.dk with SMTP; 27 Jul 2004 22:48:24 -0000 X-VirusChecked: Checked X-Env-Sender: okiddle@yahoo.co.uk X-Msg-Ref: server-9.tower-36.messagelabs.com!1090928502!8037165 X-StarScan-Version: 5.2.10; banners=-,-,- X-Originating-IP: [158.234.9.163] Received: (qmail 31192 invoked from network); 27 Jul 2004 11:41:42 -0000 Received: from iris.logica.co.uk (158.234.9.163) by server-9.tower-36.messagelabs.com with SMTP; 27 Jul 2004 11:41:42 -0000 Received: from trentino.logica.co.uk ([158.234.142.61]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id i6RBffUI022257; Tue, 27 Jul 2004 12:41:42 +0100 Received: from trentino.logica.co.uk (localhost [127.0.0.1]) by trentino.logica.co.uk (Postfix) with ESMTP id A24D47AB6CBB; Tue, 27 Jul 2004 13:40:56 +0200 (CEST) Cc: zsh-workers@sunsite.dk (Zsh hackers list) X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: <200407261346.i6QDklDr010975@news01.csr.com> From: Oliver Kiddle References: <200407261346.i6QDklDr010975@news01.csr.com> To: Peter Stephenson Subject: Re: PATCH: kfmclient and MIME type completion Date: Tue, 27 Jul 2004 13:40:56 +0200 Message-ID: <13376.1090928456@trentino.logica.co.uk> X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=-0.9 required=6.0 tests=BAYES_10 autolearn=no version=2.63 X-Spam-Hits: -0.9 [I'm resending this because it didn't come through yesterday. Sorry if it now comes through twice.] Peter wrote: > +# This is the same style as used by zsh-mime-setup, with a different > +# context. > +if zstyle -a ":completion:${curcontext}:mime" mime-types type_files; then Why do you use `mime' as the tag? It should either be empty or the same as the tag used when adding matches (such as mime-types). > + _wanted mimetype expl 'MIME type' \ The convention is for tags to be plural. We also seem to use hyphens to separate words so I'd use mime-types and mime-subtypes for the tags. > +[[ $state = *arg ]] || return 1 > + > +# Argument to previous command. > + > +print $line >/tmp/tmp.out That looks like remnant debug which we won't want. Oliver