From: Frank Terbeck <ft@bewatermyfriend.org>
To: zsh-workers@zsh.org
Cc: Nick Bryda <nickbryda@gmx.us>
Subject: [PATCH] Include zshterm.h to silence a warning
Date: Sat, 6 Apr 2013 21:36:48 +0200 [thread overview]
Message-ID: <1365277008-14246-1-git-send-email-ft@bewatermyfriend.org> (raw)
In-Reply-To: <1565658.2bmoXxmgiv@thuban>
Nick Bryda <nickbryda@gmx.us> wrote:
> I'm getting a build error with 5.0.2 on Ubuntu 12.10. The error is
>
> Function `tgoto' implicitly converted to pointer at
> ../../../Src/Zle/zle_refresh.c:2361
[...]
> This is often due to a missing function prototype definition.
>
> Since use of implicitly converted pointers is always fatal to the
> application on ia64, they are errors. Please correct them for your
> next upload.
[...]
This looks like a missing header inclusion, that causes the missing
prototype. `tgoto()' should be defined in "term.h". For portability
reasons, zsh wraps that file into `Src/zshterm.h' - so include that.
---
The default zsh build doesn't trigger this warning, at least not with
gcc 4.7.2 on amd64.
I didn't see many explicit includes in module sources. So if there is
some magic going on, that I am not aware of, please tell me. If not,
if someone knowledgeable could ACK this, I'd push the change to the
central repository.
Src/Zle/zle_refresh.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Src/Zle/zle_refresh.c b/Src/Zle/zle_refresh.c
index 17b78ce..15fbdf1 100644
--- a/Src/Zle/zle_refresh.c
+++ b/Src/Zle/zle_refresh.c
@@ -28,6 +28,7 @@
*/
#include "zle.mdh"
+#include "../zshterm.h"
#ifdef MULTIBYTE_SUPPORT
/*
--
1.8.2.rc1
next prev parent reply other threads:[~2013-04-06 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:19 Function tgoto implicitly converted to pointer Nick Bryda
2013-04-06 19:36 ` Frank Terbeck [this message]
2013-04-07 11:24 ` Axel Beckert
2013-04-07 17:40 ` Nick Bryda
2013-04-08 14:34 ` Clemens Huebner
2013-04-07 17:24 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365277008-14246-1-git-send-email-ft@bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=nickbryda@gmx.us \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).