From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2669 invoked by alias); 7 Dec 2016 12:51:34 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40119 Received: (qmail 20253 invoked from network); 7 Dec 2016 12:51:34 -0000 X-Qmail-Scanner-Diagnostics: from nm2-vm6.bullet.mail.ir2.yahoo.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(212.82.96.86):SA:0(-0.7/5.0):. Processed in 1.800447 secs); 07 Dec 2016 12:51:34 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: okiddle@yahoo.co.uk X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.mail.yahoo.com designates 212.82.96.86 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1481114726; bh=MeThrNVo7TtnP/lLykhoL7mJCXB3tAUAjKYoV2oVOF0=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=iMgJmhqoHaqXkju6PwZ1wRGSsEagFxe+E8mjrlOFctzoPoHe0ytEOqav4QFaRfKDJzMZ7HGzBOW+B90yr2HX501xvC/sUFC5E2PLTU4WfcaqxFDeJJkmpX1xrCTyMcaXyayXOaCuiOwwZMCwjeNEDLovkqPQD1xhokSCD5DjpsGq10I9HZj52/KcnXwrYl1C916wl+j1AHJp2SHiLs9PtMzm2g+tFvqdxy+9pLzYif05Fmq512LBVal0eNOJRKwash1VJhapMYfcX+/hVTp2Nmd91TfJCEZIewknWlOlzg3nq2gyaEcclLB9erl2uVs7jlLItjxYnYb7rFTDJpSxCw== X-Yahoo-Newman-Id: 532902.26868.bm@smtp141.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: gJj6.qQVM1mJWS199F9t6LnK3gDZ78KNNjjuC7iczF82_gn Qtx6pTp7XQbCZPdOo6WDn7g04om9XdboM6P6AW.CSmPjRyqqvhzIlxDPptfC a2TaKQEMo461BMljzZVdq6tIYYQJO2.fnlEDjk4oha00mCRNkYEmgxTiSKnf mIKEdAxIqfYlAm9mG6j0d.It5RzQGaJ2tzPCg4q4J96B4ZRQ2.NCCY3HUAWX 7JFgLqI.IJrwJ5E3FEf6FNmwN16flQddfYGBwtK_a9cSAwV2TUUjyO5ySBLW w.IB05ND5yKJduYOyWCchi0X0aT4iCTGwwS6oGSRNNIhdHJgwZ4f0gml3J5Y Avy9l3icLGmORPyuzYA3_G41XVtnrjvUKiDPvGDfmBIXcV3rlEq5pDBv3A11 qzdkyjXJYIiNWLTU9XhSENGCw6txn_SXD4eCZdqmw6BHa42fB0I.ci3OptIk OFXsXedQ9Ti2ywhKeNvhAMVUMCHsoaC0p.6dIBGVE3mowo7eyMDqRdCMJX1_ pE.7V1QSge2SiYseRK0lyL0Y_yZtj4TuCbm8.b2j_ X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- In-reply-to: <20161207120835.GA1828@fujitsu.shahaf.local2> From: Oliver Kiddle References: <20161207120835.GA1828@fujitsu.shahaf.local2> To: Eitan Adler , Zsh hackers list Subject: Re: [patch] minor patch to remove duplicates MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13921.1481114725.1@hydra.kiddle.eu> Date: Wed, 07 Dec 2016 13:45:25 +0100 Message-ID: <13922.1481114725@hydra.kiddle.eu> Daniel Shahaf wrote: > The patch changed the meaning of this sentence. Wasn't the sentence > more accurate before the patch? Prompted by this, I had a closer look and the following is also not the right fix: --- a/Src/zsh.h +++ b/Src/zsh.h @@ -1589,7 +1589,7 @@ struct zpc_disables_save { /* * Bit vector of ZPC_COUNT disabled characters. * We'll live dangerously and assumed ZPC_COUNT is no greater - * than the number of bits an an unsigned int. + * than the number of bits an unsigned int. The original intention was probably "in an". Oliver