From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27289 invoked by alias); 25 Jan 2014 19:15:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32305 Received: (qmail 15030 invoked from network); 25 Jan 2014 19:15:36 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, T_FRT_FOLLOW2 autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140125111530.ZM21792@torch.brasslantern.com> Date: Sat, 25 Jan 2014 11:15:30 -0800 In-reply-to: <3511.1390605547@thecus.kiddle.eu> Comments: In reply to Oliver Kiddle "Re: zle: vi mode: wrong undo handling on fresh lines" (Jan 25, 12:19am) References: <20130923213014.15f97f9e@pws-pc.ntlworld.com> <3511.1390605547@thecus.kiddle.eu> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: zle: vi mode: wrong undo handling on fresh lines MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Jan 25, 12:19am, Oliver Kiddle wrote: } } I find the effect of this change to undo to be very annoying. Typically } undo now wipes the whole buffer which isn't much use. In particular, the } old behaviour of undo after a completion is important to me. I } understand that it rightly should be marking the start of an insertion } at this point. Yes, I think it's a bug that completion doesn't behave as if you've left and then re-entered insert mode. That's a bit different than what you mentioned about the vim behavior. } However, even aside from that, the change doesn't seem to } be quite right: e.g. vi-repeat (dot) can't repeat the initial insertion. Worse than that, vi-repeat forllowing the initial insertion repeats the accept-line from the end of the previous command, thus attempting to execute the (usually partial) current command line immediately. Clearly more is needed to properly set up the vi-mode state at the start of the buffer.