From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: zle: vi mode: wrong undo handling on fresh lines
Date: Mon, 27 Jan 2014 08:29:02 -0800 [thread overview]
Message-ID: <140127082902.ZM19971@torch.brasslantern.com> (raw)
In-Reply-To: <20140127124301.4144f2d9@pwslap01u.europe.root.pri>
On Jan 27, 12:43pm, Peter Stephenson wrote:
} Subject: Re: zle: vi mode: wrong undo handling on fresh lines
}
} On Sat, 25 Jan 2014 11:15:30 -0800
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} >
} > Yes, I think it's a bug that completion doesn't behave as if you've
} > left and then re-entered insert mode.
}
} So presumably startvichange() needs calling somewhere else?
I'm not sure that's exactly it, since we're already in insert mode ...
} There is some interaction with completion in the top-level
} docomplete() call:
}
} /* For vi mode, reset the start-of-insertion pointer to the beginning *
} * of the word being completed, if it is currently later. Vi itself *
} * would never change the pointer in the middle of an insertion, but *
} * then vi doesn't have completion. More to the point, this is only *
} * an emulation. */
That's kind of related, I think. A single undo should not cross over
the insertion point, so if we've moved that, we should have started a
new undo event.
} Maybe there needs to be a hook from the outside world.
Either that or (shudder) we need vi- wrapped versions of the completion
widgets.
} > Clearly more is needed to properly set up the vi-mode state at the start
} > of the buffer.
}
} That kind of suggests there's some stuff startvitext() or
} startvichange() ought to be doing already but isn't, but we've got away
} with it somehow.
OH! The problem seems to be that startvichange() always initializes
vichgbuf[0] = lastchar, and lastchar is still the trailing '\r' from
the previous command. Is it safe to initialize lastchar = 0 when we
enter a new ZLE?
prev parent reply other threads:[~2014-01-27 16:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 12:37 Hauke Petersen
2013-09-22 18:24 ` Bart Schaefer
2013-09-22 20:27 ` Hauke Petersen
2013-09-23 4:57 ` Bart Schaefer
2013-09-23 20:30 ` Peter Stephenson
2014-01-24 23:19 ` Oliver Kiddle
2014-01-25 19:15 ` Bart Schaefer
2014-01-27 12:43 ` Peter Stephenson
2014-01-27 16:11 ` Peter Stephenson
2014-01-28 14:58 ` Peter Stephenson
2014-01-28 16:28 ` Bart Schaefer
2014-01-28 16:47 ` Peter Stephenson
2014-01-28 17:41 ` Bart Schaefer
2014-01-28 23:00 ` Oliver Kiddle
2014-01-29 2:59 ` Bart Schaefer
2014-01-29 10:50 ` Oliver Kiddle
2014-01-29 14:48 ` Bart Schaefer
2014-01-30 14:51 ` Jun T.
2014-01-30 15:38 ` Peter Stephenson
2014-01-30 16:03 ` Bart Schaefer
2014-01-31 12:00 ` Jun T.
2014-01-31 15:19 ` Bart Schaefer
2014-01-31 15:33 ` Peter Stephenson
[not found] ` <16181.1391175951@thecus.kiddle.eu>
2014-01-31 16:43 ` Jun T.
2014-01-31 21:37 ` Oliver Kiddle
2014-01-31 22:32 ` Oliver Kiddle
2014-02-01 19:27 ` Bart Schaefer
2014-02-03 16:20 ` Jun T.
2014-02-03 21:29 ` Oliver Kiddle
2014-02-03 22:20 ` Bart Schaefer
2014-02-03 23:26 ` Oliver Kiddle
2014-02-04 17:11 ` Jun T.
2014-02-05 22:00 ` Oliver Kiddle
2014-02-02 22:10 ` Oliver Kiddle
2014-02-07 14:43 ` Oliver Kiddle
2014-02-07 16:22 ` Bart Schaefer
2014-01-27 16:29 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140127082902.ZM19971@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).