From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18096 invoked by alias); 7 Feb 2014 16:22:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32363 Received: (qmail 19796 invoked from network); 7 Feb 2014 16:22:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140207082212.ZM28828@torch.brasslantern.com> Date: Fri, 07 Feb 2014 08:22:12 -0800 In-reply-to: <17050.1391784236@thecus.kiddle.eu> Comments: In reply to Oliver Kiddle "Re: zle: vi mode: wrong undo handling on fresh lines" (Feb 7, 3:43pm) References: <20130923213014.15f97f9e@pws-pc.ntlworld.com> <3511.1390605547@thecus.kiddle.eu> <140125111530.ZM21792@torch.brasslantern.com> <20140127124301.4144f2d9@pwslap01u.europe.root.pri> <20140127161124.2aa16b37@pwslap01u.europe.root.pri> <2700.1390950035@thecus.kiddle.eu> <17050.1391784236@thecus.kiddle.eu> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: zle: vi mode: wrong undo handling on fresh lines MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Feb 7, 3:43pm, Oliver Kiddle wrote: } } > - if (undoing) } > - setlastline(); } > + setlastline(); } } I think this line should just } be removed as it doesn't make much sense anyway. It's quite possible that whatever effect that was supposed to have has been obsoleted by other code added in the last 14+ years! } It was added in workers/8590 (a reply to 8574). Removing it doesn't seem } to cause problems that I can find though the examples in 8574 seem } broken in other ways. I tried all the examples in 8574 except for the last (undo-related) few. They all worked for me ... however I didn't go so far as to try them with no styles at all. One thing about the "ls /u/i/s*/f*.h" example ... although it works, on my machine there are two matches ("sys" and "selinux") for the "s*" component, and when those are presented in a menu the cursor remains at the end of the word so there's no simple way to chose one of the two and then continue expanding "f*.h". You have to hit left/right or space/backspace to interrupt cycling between those two choices before hitting TAB again.