From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Commit 137b15a fails X02zlevi test
Date: Sun, 09 Feb 2014 10:53:43 -0800 [thread overview]
Message-ID: <140209105343.ZM24252@torch.brasslantern.com> (raw)
In-Reply-To: <140208144555.ZM16333@torch.brasslantern.com>
On Feb 8, 2:45pm, Bart Schaefer wrote:
} Subject: Re: Commit 137b15a fails X02zlevi test
}
} The problem stems from the same zpty used for all the tests, and there
} is something about the "zletest" function that leaves the zpty in a
} bad state for a subsequent "comptesteval". Oddly, two "zletest" calls
} in a row do not encounter whatever situation this is.
I've been repeatedly running
make check TESTNUM=X02
and have decided that it fails nondeterministically. Sometimes the
slave side of the zpty is able to read parts of its input twice and
other times it is not. Every now and then it will go through all
tests succeeding and then on the next attempt a random one of the
tests will fail. It's never the very first test; most often but not
always, it's the first test among the second or later that begins
with a call to "comptesteval".
I've tried:
- adding "sleep" at various places to try to resolve race conditions;
- setting BUFFER="" in zle-finish and making sure "zle -R" is called
before send-break;
- changing the key binding of zle-finish (and correspondingly the
character written by zletest) so that comptesteval can't trip
zle-finish accidentally on end of line;
- adding "zle -t -r ..." in various places to be sure all output to
the pty has been consumed between tests.
None of these resolve it. The last one produces successful tests more
often, but seems to increase the randomness of which test fails the
rest of the time. I've run out of ideas ...
next prev parent reply other threads:[~2014-02-09 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 20:13 Bart Schaefer
2014-02-08 22:45 ` Bart Schaefer
2014-02-09 18:53 ` Bart Schaefer [this message]
2014-02-09 21:00 ` Peter Stephenson
2014-02-09 22:30 ` Oliver Kiddle
2014-02-11 7:37 ` Bart Schaefer
2014-02-13 5:49 ` Bart Schaefer
2014-02-13 9:32 ` Peter Stephenson
2014-02-13 16:17 ` Jun T.
2014-02-13 17:39 ` Bart Schaefer
2014-02-14 15:59 ` Jun T.
2014-02-15 1:42 ` Bart Schaefer
2014-02-15 17:07 ` Jun T.
2014-02-15 21:35 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140209105343.ZM24252@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).