zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Commit 137b15a fails X02zlevi test
Date: Thu, 13 Feb 2014 09:39:20 -0800	[thread overview]
Message-ID: <140213093920.ZM27020@torch.brasslantern.com> (raw)
In-Reply-To: <E1B1A4F0-6643-4817-8930-CF876EB414E5@kba.biglobe.ne.jp>

On Feb 14,  1:17am, Jun T. wrote:
}
} With the Bart's zpty_flush patch in 32377, it succeeds about 50%
} on Mac but still fails 100% on FreeBSD.
} On Both systems, the failure is at
}   comptesteval 'bindkey -a "^R" redo'
}   zletest $'123\C-_\e\C-r
} and all the other tests pass.
} (if I set ZTST_verbose=3 then the above test also succeeds always).

Hmm.  This suggests a race condition where some multi-character
sequence is being mis-interpreted.  I suspect that what happens is
that terminal control sequences are being sent by the on-pty zsh
to update the display, but the pty-master zsh is consuming e.g. the
leading ESC character first, so the "terminal" ignores the rest and
leaves it to be misinterpred later by one shell or the other.

A "sleep 1" at the top of zpty_flush may take care of this.

} # I noticed that 'stty -a' shows 'reprint' is set to '^R',

We should try to avoid characters that clash with the stty controls.
comptestinit should probably clear most of those at the same time it
sets the baud rate, etc., so that the tests are free to use anything
they like (except ^M ...)  I won't be able to look at this until this
evening at the earliest.


  reply	other threads:[~2014-02-13 17:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 20:13 Bart Schaefer
2014-02-08 22:45 ` Bart Schaefer
2014-02-09 18:53   ` Bart Schaefer
2014-02-09 21:00     ` Peter Stephenson
2014-02-09 22:30     ` Oliver Kiddle
2014-02-11  7:37       ` Bart Schaefer
2014-02-13  5:49         ` Bart Schaefer
2014-02-13  9:32           ` Peter Stephenson
2014-02-13 16:17           ` Jun T.
2014-02-13 17:39             ` Bart Schaefer [this message]
2014-02-14 15:59               ` Jun T.
2014-02-15  1:42                 ` Bart Schaefer
2014-02-15 17:07                   ` Jun T.
2014-02-15 21:35                     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140213093920.ZM27020@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).