zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@tiny.zanshin.com>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: 3.1.5-pws-10 and then some: _match_test is too strict
Date: Wed, 3 Mar 1999 00:36:02 -0800 (PST)	[thread overview]
Message-ID: <14044.62578.384100.791572@localhost.localdomain> (raw)

I just applied all the patches from Sven, Peter, and Matt that have
appeared since pws-10, configured with --disable-dynamic, compiled
without a hitch, ran the new zsh, set up my fpath and sourced the
compinit file.

And no file-related completions worked for me at all.

After staring at the output of repeated completions with `set -vx` in
effect, I finally concluded that the culprit is _match_test.  It seems
that you must have at least one compctl -M spec in effect in order for
_match_test to return true.  Since I don't have any compctl -M at all
and don't particularly want any at the moment, this would appear to be
a minor drawback to the current system.

I realize _match_test is intended to be edited to reflect the user's
personal matcher settings, but it ought to work "out of the box" in a
`zsh -f` situation, oughtn't it?

The following appears to deal with it; does it break something when
there *are* matcher specs?  What's the point of testing for exactly
the first matcher spec, anyway?

Index: Completion/Base/_match_test
===================================================================
diff -u -r1.2 _match_test
--- _match_test	1999/03/03 07:31:03	1.2
+++ _match_test	1999/03/03 08:28:46
@@ -12,4 +12,4 @@
 # match specifications and modify the function `_match_pattern' to build the
 # pattern to use in the calling function.
 
-(( compstate[matcher] == 1 ))
+(( compstate[matcher] <= 1 ))


             reply	other threads:[~1999-03-03  8:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-03-03  8:36 Bart Schaefer [this message]
1999-03-03  8:58 Sven Wischnowsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14044.62578.384100.791572@localhost.localdomain \
    --to=schaefer@tiny.zanshin.com \
    --cc=schaefer@zanshin.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).