From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14819 invoked by alias); 3 Jul 2014 20:30:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32837 Received: (qmail 20462 invoked from network); 3 Jul 2014 20:30:34 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=message-id:subject:from:to:date:content-type:mime-version; bh=MyOnzIsAK5xj9bThtBuP4nX7YURIvzo4Bv0ZR2DnwK0=; b=08Z18bejgpOhzV4a2Veg60iS8D84W59o5hqJ7Dro9RUgiBPRNl0Wxeoa8MJKNAnZ3S qpb9ALOf7Q3cVwAp99mG8K1P4x1TEjGJFpi5dttMMICSAgb93TCLomwAi5clO2ZIXr4k ttuv5a0sELQty15UgfQXN8dKTTqElvneVwYxdQo24MFQjRVGWq7gRHTJlfrOIdOmcsAV Rtw01gzNwrCrVF4wXPHCtaVduwr9xy7GjdYIZGuZjg85B4zCDrhIj5ruO5toAKVX2zAK 1/ljg5MuToEgjM04vT4VGDI8Nmf1CaGOvQJ1WFXUs7SWspKVzIk5irm184poj2ZAsdT8 SC3g== X-Received: by 10.180.83.225 with SMTP id t1mr13140116wiy.28.1404412974727; Thu, 03 Jul 2014 11:42:54 -0700 (PDT) Message-ID: <1404412968.4217.12.camel@hellraiser.hellfire.rockserve.de> Subject: runhelpdir Issues with building Zsh 5.0.5 for Fedora From: Dominic Hopf To: zsh-workers@zsh.org Date: Thu, 03 Jul 2014 20:42:48 +0200 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-KUT+PRwC++yftfrqa5qO" X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 --=-KUT+PRwC++yftfrqa5qO Content-Type: multipart/mixed; boundary="=-HuVC+X/FwWqbS/oKPqoY" --=-HuVC+X/FwWqbS/oKPqoY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Greetings, attached patch is at least necessary to successfully build the latest Zsh release on Fedora, please have a look at it as it might be useful in other cases as well or possibly also could be applied upstream. Furthermore, I have to set the runhelpdir path to the buildroot of the package as it happened before for several other paths as well. The install-section of the RPM spec file looks like this then: %makeinstall install.info \ fndir=3D$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/functions \ sitefndir=3D$RPM_BUILD_ROOT%{_datadir}/%{name}/site-functions \ scriptdir=3D$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/scripts \ sitescriptdir=3D$RPM_BUILD_ROOT%{_datadir}/%{name}/scripts \ runhelpdir=3D$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/help This unfortunately causes the whole path, including the buildroot itself to be written into the files /usr/share/zsh/5.0.5/functions/{run-help,_run-help} which of course will not work and is claimed by rpmbuild: + /usr/lib/rpm/check-buildroot /home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5= /functions/_run-help:local HELPDIR=3D${HELPDIR:-/home/dmaphy/rpmbuild/BUILD= ROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/help} /home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5= /functions/run-help:local HELPDIR=3D"${HELPDIR:-/home/dmaphy/rpmbuild/BUILD= ROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/help}" Found '/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64' in installed files; aborting error: Bad exit status from /home/dmaphy/.tmp/rpm-tmp.kg39RI (%install) Currently I'm fixing this in the package using sed to remove the buildroot again where it is not needed: sed -i "s!$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/help! %{_datadir}/%{name}/%{version}/help!" \ $RPM_BUILD_ROOT %{_datadir}/zsh/%{version}/functions/{run-help,_run-help} As far as I can see there is happening something weird with the runhelpdir within the build process I didn't understand into detail but luckily was able to fix so far. I'd appreciate if someone could have a deeper look into this and tell me if I ran into a bug or if I'm basically doing something wrong. Thanks very much in advance & Best Regards, Dominic --=20 Dominic Hopf=20 http://dominichopf.de/ Key Fingerprint: A7DF C4FC 07AE 4DDC 5CA0 BD93 AAB0 6019 CA7D 868D --=-HuVC+X/FwWqbS/oKPqoY Content-Disposition: attachment; filename="0000-zsh-fix-runhelpdir-issue.patch" Content-Type: text/x-patch; name="0000-zsh-fix-runhelpdir-issue.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 LS0tIHpzaC01LjAuNS9Db25maWcvZGVmcy5tay5pbi5vcmlnaW5hbAkyMDE0LTA2LTMwIDIwOjQ4 OjQxLjA5NTk3NzY0NiArMDIwMA0KKysrIHpzaC01LjAuNS9Db25maWcvZGVmcy5tay5pbgkyMDE0 LTA2LTMwIDIwOjQ5OjA2LjEzMjA3NjY5OCArMDIwMA0KQEAgLTk1LDcgKzk1LDcgQEANCiBNQUtF REVGUyA9IFwNCiBwcmVmaXg9JyQocHJlZml4KScgZXhlY19wcmVmaXg9JyQoZXhlY19wcmVmaXgp JyBiaW5kaXI9JyQoYmluZGlyKScgXA0KIGxpYmRpcj0nJChsaWJkaXIpJyBNT0RESVI9JyQoTU9E RElSKScgaW5mb2Rpcj0nJChpbmZvZGlyKScgbWFuZGlyPSckKG1hbmRpciknIFwNCi1kYXRhZGly PSckKGRhdGFkaXIpJyBmbmRpcj0nJChmbmRpciknIGh0bWxkaXI9JyQoaHRtbGRpciknIFwNCitk YXRhZGlyPSckKGRhdGFkaXIpJyBmbmRpcj0nJChmbmRpciknIGh0bWxkaXI9JyQoaHRtbGRpcikn IHJ1bmhlbHBkaXI9JyQocnVuaGVscGRpciknIFwNCiBDQz0nJChDQyknIENQUEZMQUdTPSckKENQ UEZMQUdTKScgREVGUz0nJChERUZTKScgQ0ZMQUdTPSckKENGTEFHUyknIFwNCiBMREZMQUdTPSck KExERkxBR1MpJyBFWFRSQV9MREZMQUdTPSckKEVYVFJBX0xERkxBR1MpJyBcDQogRExDRkxBR1M9 JyQoRExDRkxBR1MpJyBETExERkxBR1M9JyQoRExMREZMQUdTKScgXA0K --=-HuVC+X/FwWqbS/oKPqoY-- --=-KUT+PRwC++yftfrqa5qO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlO1pCwACgkQqrBgGcp9ho1OngCbBEikXGakubn/Y8Zt6bj04BP6 y7kAnjAh73cmviOF4o9yGXGOkA8L3qKX =Bmwv -----END PGP SIGNATURE----- --=-KUT+PRwC++yftfrqa5qO--