Count of last matches (was: RE: Reading completion manual)

Count of last matches (was: RE: Reading completion manual)

[Andrej Borsenkow]

>
>
> Applied to all three: what about some return code to indicate, if
> some matches were added? Currently one has to save, and then
> compare, compstate[nmatches], that looks somewhat ugly. Using
> return code would provide for
>
> compgen -k friends || compgen -u
>
> Looks better for me. Probably, this idea could be used for all
> helper functions as well - is it useful?
>


What about following: add new item to compstate, say, last_nmatches, that
hold count of matches added by the *last* used compgen, compadd, compcall.
That can be used to test if we got something, and probably may be useful for
other tasks as well. And definitely better

if [[ $compstate[last_nmatches] -gt 0 ]]

than current

save nmatches
call completion
compare

cheers

/andrej

Re: Count of last matches (was: RE: Reading completion manual)

[Bart Schaefer]

Andrej Borsenkow writes:
 > 
 > > Applied to all three: what about some return code to indicate, if
 > > some matches were added? Currently one has to save, and then
 > > compare, compstate[nmatches], that looks somewhat ugly. Using
 > > return code would provide for
 > >
 > > compgen -k friends || compgen -u
 > 
 > What about following: add new item to compstate, say, last_nmatches,
 > that hold count of matches added by the *last* used compgen, compadd,
 > compcall.

That might be useful, but I think the most useful bit of information is
whether anything at all was added (or whether the calling function
should behave as if anything at all was added, which may be a different
thing).

So even if a last_nmatches key were added to compstate, I'd still be in
favor of a useful return value from compgen et al.

Re: Count of last matches (was: RE: Reading completion manual)

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> What about following: add new item to compstate, say, last_nmatches, that
> hold count of matches added by the *last* used compgen, compadd, compcall.
> That can be used to test if we got something, and probably may be useful for
> other tasks as well. And definitely better
> 
> if [[ $compstate[last_nmatches] -gt 0 ]]

Easy to add. Some more feedback?

> than current
> 
> save nmatches
> call completion
> compare

You don't like shell code, do you? ;-)

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de