Variable completion in pws-11

Variable completion in pws-11

[Vin Shelton]

echo $ZSH<TAB> just beeps at me in pws-11.  It did the right thing in pws-10 - 
it offered me the menu of ZSH_NAME or ZSH_VERSION.  

: ~ Sun 7 18:20; echo $ZSH<TAB>
                           ^
                           +---- This just beeps.

BTW, both echo and print have the same behavior.  This behavior occurs even
with zsh -f.

Is this an intentional change?  Do I need to set a new option?

Thanks,
  vin shelton

Re: Variable completion in pws-11

[Bart Schaefer]

Vin Shelton writes:
 > echo $ZSH<TAB> just beeps at me in pws-11.

I can confirm that some of the built-in completions seem to have gone
south.  This works if I load up Completion/Core/compinit, but it does
not work with zsh -f.  The patch that introduced check_param() is the
one that broke it, but I'm not sure exactly how.

Does anybody know the full list of completions that worked in zsh -f
as of 3.1.[45] ?  Nine of the default compctls of 3.0.5 went away in
about 3.1.2, but command completion and default file completion both
still worked.  Then there's a short list of completions that were not
previously under user control, which included parameter completion
after a $ sign and ... what else?  Sven, have you tested these to be
sure they still work?

Re: Variable completion in pws-11

[Sven Wischnowsky]

Bart Schaefer wrote:

> Vin Shelton writes:
>  > echo $ZSH<TAB> just beeps at me in pws-11.
> 
> I can confirm that some of the built-in completions seem to have gone
> south.  This works if I load up Completion/Core/compinit, but it does
> not work with zsh -f.  The patch that introduced check_param() is the
> one that broke it, but I'm not sure exactly how.
> 
> Does anybody know the full list of completions that worked in zsh -f
> as of 3.1.[45] ?  Nine of the default compctls of 3.0.5 went away in
> about 3.1.2, but command completion and default file completion both
> still worked.  Then there's a short list of completions that were not
> previously under user control, which included parameter completion
> after a $ sign and ... what else?  Sven, have you tested these to be
> sure they still work?

Yes, I tested ~ and = (and file and command-position) completion, but
forgot to restrict the completion string after a $ only
conditionally. With 5670 everything looks as before again.

Sorry.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: Variable completion in pws-11

[Sven Wischnowsky]

Vin Shelton wrote:

> echo $ZSH<TAB> just beeps at me in pws-11.  It did the right thing in pws-10 - 
> it offered me the menu of ZSH_NAME or ZSH_VERSION.  
> 
> : ~ Sun 7 18:20; echo $ZSH<TAB>
>                            ^
>                            +---- This just beeps.
> 
> BTW, both echo and print have the same behavior.  This behavior occurs even
> with zsh -f.

Sorry, this was lost (with old-style completion) when adding the
`parameter' context for new style completion.

Bye
 Sven

diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c	Mon Mar  8 09:06:41 1999
+++ Src/Zle/zle_tricky.c	Mon Mar  8 09:16:20 1999
@@ -5315,7 +5315,7 @@
     char *p, *os = s;
 
     /* Inside $... ? */
-    if ((p = check_param(s, 0)))
+    if (compfunc && (p = check_param(s, 0)))
 	os = s = p;
 
     /* We build a copy of the list of matchers to use to make sure that this

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de