From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Parser issues and and [[ $var ]]
Date: Sat, 10 May 2014 18:01:44 -0700 [thread overview]
Message-ID: <140510180144.ZM26488@torch.brasslantern.com> (raw)
In-Reply-To: <140510140932.ZM32668@torch.brasslantern.com>
I've found a couple of other bugs with 32604, so it's probably just as
well that I didn't commit/push it. Does anyone know why the lexer
sometimes sets (tok = DOUTBRACK, tokstr = "\220\220") and other times
(tok = DOUTBRACK, tokstr = NULL) ?
It would seem as though it ought to be consistent. It does seem to
consistently "return" (tok = DAMPER, tokstr = NULL) for example.
On May 10, 2:09pm, Bart Schaefer wrote:
}
} [ -t ] >/dev/null
}
} is true in bash3.2 but false in ksh93 (including builtin test). As far
} as I can tell, this is the only operator that behaves this way, both
} bash and ksh treat all other binary operators as strings when they
} have no argument.
Of course I meant to write "prefix operators" not "binary".
} I think the following produces syntax errors in all the places it should
} and works in the rest of the cases, but I have not yet tested it with
} new conditionals added by modules -- e.g., the recomputation of dble
} for s2 (last hunk) may need knowledge of added conditions.
With the patch from 32604 in place, I added a simple prefix operator to
the example module:
CONDDEF("m", 0, cond_p_m, 0, -1, 0),
This should accept any number of arguments including none. I created
cond_p_m() to return 0 if there are no arguments and 1 if there are
any arguments (recall that the C function return values are inverted
from the shell true/false return status).
After recompiling and loading zsh/example, [[ -m ]] returns true. GDB
confirms that cond_p_m() is never being called. The condition callback
is correctly invoked for [[ -m 1 2 ]] etc.
On the other hand, WITHOUT 32604, [[ -m ]] is a parse error, so it would
appear that prefix operators are not allowed to have no arguments. This
should probably be documented.
Back on the first hand, in ksh93 [[ -z ]] is a parse error (that is, a
prefix operator is never tested as a plain string except in "test")
whereas [[ -m ]] is not (because there is no -m operator). So it would
seem that once an operator is defined, it should not be allowed to
parse as a string.
Thus it would seem that the parser does need a way to explicitly test
for module-defined operators to also support non-operator non-empty
strings evaluating as true. Or, we can decree that any string that
starts with a "-" is treated as an operator, since all module-defined
operators must start with "-", which would differ from ksh93 but not
from previous zsh. (foo=-m; [[ $foo ]]) would still test as a string.
next prev parent reply other threads:[~2014-05-11 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAH_OBicpVKS-URnd-Gq=gj+qc6OhDCqf0mgDfVcda27mEEfUKg@mail.gmail.com>
[not found] ` <140416102727.ZM19090@torch.brasslantern.com>
[not found] ` <CAH_OBic7sX1Oc4VWn2KvX40smbRB6A7w8QGXLvPfZLD=CHMddQ@mail.gmail.com>
[not found] ` <534FE710.3020601@eastlink.ca>
[not found] ` <140417123722.ZM22179@torch.brasslantern.com>
[not found] ` <20140423165024.1480528a@pws-pc.ntlworld.com>
[not found] ` <lj984r$6uo$1@ger.gmane.org>
[not found] ` <CAHYJk3QOZTnicq+Nqg4BXNANa_c6_j5mhyQNK1f8YNtDhxixgA@mail.gmail.com>
[not found] ` <slrnlll0kq.v0i.martin@lounge.imp.fu-berlin.de>
[not found] ` <20140425172112.7bf50606@pwslap01u.europe.root.pri>
[not found] ` <slrnlln1bj.a9l.martin@epidot.math.uni-rostock.de>
2014-04-26 20:30 ` Bart Schaefer
2014-05-10 21:09 ` Bart Schaefer
2014-05-11 1:01 ` Bart Schaefer [this message]
2014-05-11 17:01 ` Peter Stephenson
2014-05-11 18:12 ` Bart Schaefer
2014-05-13 5:01 ` [PATCH] " Bart Schaefer
2014-05-13 9:10 ` Peter Stephenson
2014-05-13 15:03 ` Bart Schaefer
[not found] ` <20140426212126.58b0ff26@pws-pc.ntlworld.com>
2014-04-26 21:23 ` More [[ $var ]] (Re: zsh-newuser-install) Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140510180144.ZM26488@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).