From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29000 invoked by alias); 4 Jun 2014 16:13:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32706 Received: (qmail 27273 invoked from network); 4 Jun 2014 16:13:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140604091308.ZM30534@torch.brasslantern.com> Date: Wed, 04 Jun 2014 09:13:08 -0700 In-reply-to: <20140603205607.00cc39f1@pws-pc.ntlworld.com> Comments: In reply to Peter Stephenson "Re: Bug#749969: history no longer syncs immediately, INC_APPEND_HISTORY broken" (Jun 3, 8:56pm) References: <20140531074936.GA9011@valiant.palfrader.org> <87d2eu5mmg.fsf@ft.bewatermyfriend.org> <20140531202211.396cd06e@pws-pc.ntlworld.com> <20140603205607.00cc39f1@pws-pc.ntlworld.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Bug#749969: history no longer syncs immediately, INC_APPEND_HISTORY broken MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Jun 3, 8:56pm, Peter Stephenson wrote: } } I think this works, but it's getting pretty silly. There are a number of cases where binary on/off options don't really lend themselves to describing complex behavior. } + * For INCAPPENDHISTORYTIME, when interactive, save the history here } * as it gives a better estimate of the times of commands. } * } + * If INCAPPENDHISTORY is also set we've already done it. I was somewhat concerned that this implies that given % setopt INCAPPENDHISTORY INCAPPENDHISTORYTIME % unsetopt INCAPPENDHISTORY the unsetopt command would be appended to the history more than once, but some other part of the tests apparently prevents that. The doc for INC_APPEND_HISTORY_TIME should probably point out that the option has no effect when INC_APPEND_HISTORY or SHARE_HISTORY is set, and the "you want more control" paragraph under SHARE_HISTORY might suggest INC_APPEND_HISTORY_TIME instead of INC_APPEND_HISTORY.