zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Re: (Y) modifier: up to N matches?
Date: Wed, 04 Jun 2014 21:45:09 -0700	[thread overview]
Message-ID: <140604214509.ZM31035@torch.brasslantern.com> (raw)
In-Reply-To: <CAH+w=7YJ0Y8qO3j_z4e_7cHQ857GyFOr6PXqAdvBEgUj=uhV6Q@mail.gmail.com>

On Jun 4,  4:16pm, Bart Schaefer wrote:
}
} I verified by comparing the output of **/*(odoN) vs **/*(oN) that they
} may in fact differ. I didn't dig into exactly how or why.

It appears that **/*(od) returns files in subdirectories first regardless
of any other sort flags, including (oN) which applies only to the files
within each subdirectory and to subdirectories of the same parent with
relation to each other.

Similarly (Od) displays local names first, though they may otherwise be
unordered (or at leat not predictably ordered).  Even without **/ as a
prefix, (odoN) is a different order than (oN).  This must be because an
unstable qsort is applied even though it theoretically compares all names
as equivalent.
 
} More later when I have time to peruse the patches.

Both patches look sane and simple enough.  My only quibble with the
second (1<<GF_NONE) patch is that by enumerating the states it becomes
necessary to edit this again if a new sort order is introduced, but
that doesn't happen very often so is probably moot.


  reply	other threads:[~2014-06-05  4:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 18:23 Daniel Shahaf
2014-06-03  3:46 ` Bart Schaefer
2014-06-04  2:08   ` [PATCH] " Daniel Shahaf
2014-06-04  6:01     ` Mikael Magnusson
2014-06-04  6:54       ` Bart Schaefer
2014-06-04  6:42     ` Bart Schaefer
2014-06-04  9:25       ` Peter Stephenson
2014-06-04 23:08       ` Daniel Shahaf
2014-06-04 23:16         ` Bart Schaefer
2014-06-05  4:45           ` Bart Schaefer [this message]
2014-06-05 23:24           ` Oliver Kiddle
2014-06-06  2:20             ` Bart Schaefer
2014-06-06  2:40               ` Daniel Shahaf
2014-06-06  2:45             ` Daniel Shahaf
2014-06-06  4:24               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140604214509.ZM31035@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).