From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-32739-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 28793 invoked by alias); 7 Jun 2014 19:04:46 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 32739
Received: (qmail 5974 invoked from network); 7 Jun 2014 19:04:44 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <140607120439.ZM24985@torch.brasslantern.com>
Date: Sat, 07 Jun 2014 12:04:39 -0700
In-reply-to: <1402161535-20756-1-git-send-email-nikolas@garofil.be>
Comments: In reply to Nikolas Garofil <nikolas@garofil.be>
 "[PATCH 1/6] fix implicit typecast for strict compilers" (Jun  7,  7:18pm)
References: <1402161535-20756-1-git-send-email-nikolas@garofil.be>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: [PATCH 1/6] fix implicit typecast for strict compilers
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jun 7,  7:18pm, Nikolas Garofil wrote:
}
} diff --git a/Src/compat.c b/Src/compat.c
} index cc4e876..81a95d5 100644
} --- a/Src/compat.c
} +++ b/Src/compat.c
} @@ -40,7 +40,7 @@ strstr(const char *s, const char *t)
}      char *p1, *p2;
}  
}      for (; *s; s++) {
} -        for (p1 = s, p2 = t; *p2; p1++, p2++)
} +        for (p1 = (char*)s, p2 = (char*)t; *p2; p1++, p2++)
}              if (*p1 != *p2)
}                  break;
}          if (!*p2)
} -- 


Wouldn't the right thing here be to declare

	const char *p1, *p2;

instead of casting?

-- 
Barton E. Schaefer