From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 5/6] memmove is expected to return dest
Date: Sat, 07 Jun 2014 12:15:15 -0700 [thread overview]
Message-ID: <140607121515.ZM25023@torch.brasslantern.com> (raw)
In-Reply-To: <1402161535-20756-5-git-send-email-nikolas@garofil.be>
On Jun 7, 7:18pm, Nikolas Garofil wrote:
}
} #ifndef HAVE_MEMMOVE
} -# define memmove(dest, src, len) bcopy((src), (dest), (len))
} +void *memmove(void *dest, const void *src, size_t n) {
} + bcopy(src, dest, n);
} + return dest;
} +}
} #endif
Defining a function in a .h file, especially without declaring it
static, is probably not the best idea.
Perhaps something like
#ifndef HAVE_MEMMOVE
# ifndef memmove
static void *zmm;
# define memmove(dest, src, len) (bcopy((src), zmm = (dest), (len)), zmm)
# endif
#endif
??
next prev parent reply other threads:[~2014-06-07 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 17:18 [PATCH 1/6] fix implicit typecast for strict compilers Nikolas Garofil
2014-06-07 17:18 ` [PATCH 2/6] strict compilers expect the number of bytes to be a size_t for bcopy Nikolas Garofil
2014-06-07 19:20 ` Bart Schaefer
2014-06-07 19:29 ` Nikolas Garofil
2014-06-07 17:18 ` [PATCH 3/6] make sure signal_suspend doesn't return a undefined value Nikolas Garofil
2014-06-07 17:18 ` [PATCH 4/6] strict compilers don't like pointers that get set but are never used Nikolas Garofil
2014-06-07 17:18 ` [PATCH 5/6] memmove is expected to return dest Nikolas Garofil
2014-06-07 19:15 ` Bart Schaefer [this message]
2014-06-07 17:18 ` [PATCH 6/6] decr and tmp are only used when HAVE_STRFTIME is defined, strict compilers will complain Nikolas Garofil
2014-06-07 19:04 ` [PATCH 1/6] fix implicit typecast for strict compilers Bart Schaefer
2014-06-07 19:13 ` Nikolas Garofil
2014-06-07 19:36 ` Bart Schaefer
2014-06-07 19:43 ` Nikolas Garofil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140607121515.ZM25023@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).