From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16758 invoked by alias); 7 Jun 2014 19:36:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32743 Received: (qmail 24704 invoked from network); 7 Jun 2014 19:36:01 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140607123601.ZM25178@torch.brasslantern.com> Date: Sat, 07 Jun 2014 12:36:01 -0700 In-reply-to: <5393645B.7050409@garofil.be> Comments: In reply to Nikolas Garofil "Re: [PATCH 1/6] fix implicit typecast for strict compilers" (Jun 7, 9:13pm) References: <1402161535-20756-1-git-send-email-nikolas@garofil.be> <140607120439.ZM24985@torch.brasslantern.com> <5393645B.7050409@garofil.be> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH 1/6] fix implicit typecast for strict compilers MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Jun 7, 9:13pm, Nikolas Garofil wrote: } } > Wouldn't the right thing here be to declare } > } > const char *p1, *p2; } > } > instead of casting? } } The p1 and p2 pointers are increased at the end of the line to walk } through the string so that wouldn't work The "s" pointer is declared const char * and it's incremented as well. I'm not suggesting "char * const p1".