From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27064 invoked by alias); 24 Jul 2014 15:29:04 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32907 Received: (qmail 13717 invoked from network); 24 Jul 2014 15:29:02 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140724082900.ZM18813@torch.brasslantern.com> Date: Thu, 24 Jul 2014 08:29:00 -0700 In-reply-to: <20140724104727.5b9e9e14@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: [PATCH] Re: aliases+=(foo 'echo bar') crash" (Jul 24, 10:47am) References: <20140723160935.GC7798@chaz.gmail.com> <20140723175218.1350b9cd@pwslap01u.europe.root.pri> <140723183740.ZM5114@torch.brasslantern.com> <140723200417.ZM5161@torch.brasslantern.com> <140723224535.ZM17657@torch.brasslantern.com> <20140724104727.5b9e9e14@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] Re: aliases+=(foo 'echo bar') crash MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Jul 24, 10:47am, Peter Stephenson wrote: } Subject: Re: [PATCH] Re: aliases+=(foo 'echo bar') crash } } On Wed, 23 Jul 2014 22:45:35 -0700 } Bart Schaefer wrote: } > - pm->node.flags |= PM_UNSET; } > + pm->node.flags |= (PM_UNSET|PM_SPECIAL); } } It's a bit surprising this hasn't caused mayhem before now, but I } suppose the damage is limited or non-existent until you try to set } the parameters Simple assignment via either aliases=(a b) or aliases[a]=b doesn't go through the same code path, so there was no issue until the += syntax was added ... and it's pretty unusual to append something to a hash table that way, so I'm not that surprised that no one encountered it.