zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH: Add :^ syntax for zipping two arrays (v3)
Date: Mon, 04 Aug 2014 11:36:31 -0700	[thread overview]
Message-ID: <140804113631.ZM1047@torch.brasslantern.com> (raw)
In-Reply-To: <1407171088-8740-1-git-send-email-mikachu@gmail.com>

On Aug 4,  6:51pm, Mikael Magnusson wrote:
} Subject: PATCH: Add :^ syntax for zipping two arrays (v3)
}
} This includes tests, updated docs to mention the "${a:^a}" thing, and
} fixes a crash discovered by adding tests. (When either of the arrays
} were empty, the :^^ form attempted to divide by 0).

Src/subst.c: In function `paramsubst':
Src/subst.c:2882: warning: unused variable `ap'
Src/subst.c:2882: warning: unused variable `apsrc'

diff --git a/Src/subst.c b/Src/subst.c
index fc1be7d..4a5fe3a 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -2879,7 +2879,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt, int pf_flags)
 	    break;
 	}
     } else if (inbrace && (*s == '^' || *s == Hat)) {
-	char **zip, **ap, **apsrc;
+	char **zip;
 	int shortest = 1;
 	++s;
 	if (*s == '^' || *s == Hat) {


      reply	other threads:[~2014-08-04 18:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 15:47 PATCH: Add :^ syntax for zipping two arrays (v2) Mikael Magnusson
2014-08-04  8:29 ` Peter Stephenson
2014-08-04 16:01   ` Mikael Magnusson
2014-08-04 16:07     ` Peter Stephenson
2014-08-04 16:51       ` PATCH: Add :^ syntax for zipping two arrays (v3) Mikael Magnusson
2014-08-04 18:36         ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140804113631.ZM1047@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).