From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6369 invoked by alias); 4 Aug 2014 20:53:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32962 Received: (qmail 16250 invoked from network); 4 Aug 2014 20:53:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140804135325.ZM1993@torch.brasslantern.com> Date: Mon, 04 Aug 2014 13:53:25 -0700 In-reply-to: <83960560B9A9E445909AC748DB1139982B5AB441@MX103CL01.corp.emc.com> Comments: In reply to Miles Ohlrich "suggested patch for error flagged in static analysis" (Aug 4, 7:28pm) References: <83960560B9A9E445909AC748DB1139982B5AB441@MX103CL01.corp.emc.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: "zsh-workers@zsh.org" Subject: Re: suggested patch for error flagged in static analysis MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Aug 4, 7:28pm, Miles Ohlrich wrote: } } !CMF_FILE is always 0. Should be ~CMF_FILE. } } --- zsh-5.0.5/Src/Zle/compctl.c.orig 2014-08-04 12:20:54.327001219 -0700 } +++ zsh-5.0.5/Src/Zle/compctl.c 2014-08-04 12:21:41.079945543 -0700 Wow, compctl ? This is a really ancient bug. I wonder what the effect was in practice ... it'll likely have almost no visible effect these days, as compctl is all but unused. Still, no reason not to commit it.