From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4642 invoked by alias); 12 Sep 2014 23:50:45 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33154 Received: (qmail 10484 invoked from network); 12 Sep 2014 23:50:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <140912165046.ZM23739@torch.brasslantern.com> Date: Fri, 12 Sep 2014 16:50:46 -0700 In-reply-to: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> Comments: In reply to Marc Finet "Misc patches for git completion and vcs_info" (Sep 12, 11:30pm) References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Misc patches for git completion and vcs_info MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Sep 12, 11:30pm, Marc Finet wrote: } } Below is a list of patches that i added in my current zsh (based on } tonight's master). Please consider them for review as my zsh-level is } currently very low (e.g. patch 2) and i might have broken other use-cases } (patch 4 for instance makes me a little bit nervous as it seems to easy). (I think you left out the list.) I'll leave it to one of the people who more regularly messes with VCS_Info to apply these, but here's my brief take on each of them: [PATCH 1/9] vcs_info examples: fix typo - no issues with this one [PATCH 2/9] completion git: support aliases when \n exist - looks OK, but my "git config" foo is too weak to assess PATCH 3/9] vcs_info git: detect revert or cherry-pick with multiple commits - no issues [PATCH 4/9] vcs_info git: set rrn before using it - seems pretty obvious [PATCH 5/9] vcs_info quilt: fix standalone detection - I'm not sure this is correct; do we need to differentiate (( $# == 1 )) from [[ -z "$2" ]] ? [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory - $(basename $patches) can be replaced with ${patches:t} [PATCH 7/9] vcs_info git: fix applied-string name - seems pretty obvious [PATCH 8/9] vcs_info git: consider patches for rebase - needs git foo currently beyond me to confirm correctness [PATCH 9/9] completion git: fix send-email --confirm values - no issues