From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.6 hanged in freejob from TRAPCHLD
Date: Wed, 01 Oct 2014 07:53:25 -0700 [thread overview]
Message-ID: <141001075325.ZM5718@torch.brasslantern.com> (raw)
In-Reply-To: <20141001100033.0e10a30c@pwslap01u.europe.root.pri>
On Oct 1, 10:00am, Peter Stephenson wrote:
} Subject: Re: zsh 5.0.6 hanged in freejob from TRAPCHLD
}
} > The stack trace seems to indicate that the problem likely originates in
} > lexrestore() which calls free() directly (without the signal-safe zfree()
}
} The queue_signals() is presumably important. I don't see that zfree()
} makes a practical difference here, though
Right, I realized after hitting "send" that zfree() is only signal-safe
when using zsh's mem.c malloc() replacement -- in which case free() is
also a wrapper for zfree() instead of the other way around.
This plus the possibility of interrupting the copy from the saved state
back to the globals is the need for queue_signals() inside lexrestore().
There may be other save/restore routines that still need this treatment,
I haven't yet done an audit.
next prev parent reply other threads:[~2014-10-01 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 17:21 Vincent Lefevre
2014-09-30 23:18 ` Bart Schaefer
2014-10-01 0:53 ` PATCH signal-safe lexrestore() [Re: zsh 5.0.6 hanged in freejob from TRAPCHLD] Bart Schaefer
2014-10-01 9:00 ` zsh 5.0.6 hanged in freejob from TRAPCHLD Peter Stephenson
2014-10-01 14:53 ` Bart Schaefer [this message]
2014-10-01 15:25 ` Oliver Kiddle
2014-10-01 15:40 ` Peter Stephenson
2014-10-01 16:04 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141001075325.ZM5718@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).