From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14736 invoked by alias); 1 Oct 2014 16:29:35 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33310 Received: (qmail 19259 invoked from network); 1 Oct 2014 16:29:34 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <141001092934.ZM5952@torch.brasslantern.com> Date: Wed, 01 Oct 2014 09:29:34 -0700 In-reply-to: <20141001151501.2eac05ef@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: _expand_alias does not expand aliases that contain an "!"" (Oct 1, 3:15pm) References: <140830133206.ZM13172@torch.brasslantern.com> <140831135017.ZM739@torch.brasslantern.com> <140914113029.ZM31296@torch.brasslantern.com> <140914135552.ZM31608@torch.brasslantern.com> <20141001150324.1cdad6c9@pwslap01u.europe.root.pri> <20141001150641.02e52281@pwslap01u.europe.root.pri> <20141001151501.2eac05ef@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: _expand_alias does not expand aliases that contain an "!" MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Oct 1, 3:15pm, Peter Stephenson wrote: } Subject: Re: _expand_alias does not expand aliases that contain an "!" } } On Wed, 01 Oct 2014 15:06:41 +0100 } Peter Stephenson wrote: } > On Wed, 1 Oct 2014 15:03:24 +0100 } > Peter Stephenson wrote: } > > On possible fix would be to add a separate variable to remember the } > > original ISPECIAL bit for bangchar (which would be transferable if } > > bangchar became a different character) and restore it at this point } > } > Immediately after hitting "Send"(*), it occurred to me this just needs } > to be another bit in the typtab element, ISPECIAL_ORIGINALLY } } Gag. Sorry, no, that doesn't work if we change bangchar. Maybe we just need something along the lines of makecommaspecial() that can be called from hbegin() to set ISPECIAL on bangchar, and called in the completion code to temporarily switch it off/on. Then inittyptab() never has to mess with examining bangchar, and the new makebangspecial() can be called from histcharsetfn() instead of doing a full inittyptab(). -- Barton E. Schaefer