From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: More crash Re: More incmdpos stuff Re: Crash Re: Trial for 5.0.7
Date: Fri, 03 Oct 2014 08:33:27 -0700 [thread overview]
Message-ID: <141003083327.ZM15145@torch.brasslantern.com> (raw)
In-Reply-To: <20141003161518.01cbc081@pwslap01u.europe.root.pri>
On Oct 3, 4:15pm, Peter Stephenson wrote:
} Subject: Re: More crash Re: More incmdpos stuff Re: Crash Re: Trial for 5.
}
} The explanation is I screwed up. *complex should never be set to 0
} except where the variable pointed to is created --- it should only be
} conditionally set to 1. (For zsh-shaped values of "never".)
Does that mean we need this, too?
--- a/Src/parse.c
+++ b/Src/parse.c
@@ -1517,7 +1517,8 @@ par_funcdef(int *complex)
num++;
zshlex();
}
- *cmplx = (num > 0);
+ if (num > 0)
+ *cmplx = 1;
ecbuf[parg] = ecused - parg; /*?*/
ecbuf[parg+1] = num;
}
next prev parent reply other threads:[~2014-10-03 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 11:47 Mikael Magnusson
2014-10-03 12:27 ` Peter Stephenson
2014-10-03 14:50 ` More crash " Bart Schaefer
2014-10-03 15:15 ` Peter Stephenson
2014-10-03 15:33 ` Bart Schaefer [this message]
2014-10-03 15:42 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141003083327.ZM15145@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).