From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16526 invoked by alias); 13 Oct 2014 17:17:54 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33462 Received: (qmail 29023 invoked from network); 13 Oct 2014 17:17:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Bart Schaefer Message-id: <141013101803.ZM5769@torch.brasslantern.com> Date: Mon, 13 Oct 2014 10:18:03 -0700 In-reply-to: <20141013030313.GB5405@sym.noone.org> Comments: In reply to Axel Beckert "Re: Drat, Test/A05 still hanging sometimes" (Oct 13, 5:03am) References: <141006134255.ZM22326@torch.brasslantern.com> <20141007150735.264a09fe@pwslap01u.europe.root.pri> <20141009075200.GV5405@sym.noone.org> <141012114739.ZM23982@torch.brasslantern.com> <20141013030313.GB5405@sym.noone.org> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Drat, Test/A05 still hanging sometimes MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Oct 13, 5:03am, Axel Beckert wrote: } } On Sun, Oct 12, 2014 at 11:47:39AM -0700, Bart Schaefer wrote: } > Tests in each of A01, A04, and A05 use "coproc". How does this match up } > with the hung builds you have encountered? } } Quite well -- as far as I can see there was only one exception so far: } Once it also hung inside X02zlevi.ztst. All others were either in one } of the three tests you mentioned, with A05 being the most often one } (and IIRC also the one you experience twice or so). Give the following a try? With the "sleep" in there, I am unable to make the A05 test hang. Without it, I get one hang in each 20 repeats of the test, pretty reliably. Although why putting the sleep at that particular place has the right side-effect, I do not know. diff --git a/Test/A05execution.ztst b/Test/A05execution.ztst index ca97f4f..0b40a73 100644 --- a/Test/A05execution.ztst +++ b/Test/A05execution.ztst @@ -208,6 +208,7 @@ F:This similar test was triggering a reproducible failure with pipestatus. print -u $ZTST_fd 'This test takes 5 seconds to fail...' { printf "%d\n" {1..20000} } | ( read -e ) hang(){ printf "%d\n" {2..20000} | cat }; hang | ( read -e ) + sleep 1 ;: avoid coproc exit race condition print -p done read -et 6 -p 0:Bug regression: piping a shell construct to an external process may hang