zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: MacOS X patches
Date: Wed, 05 Nov 2014 08:56:05 -0800	[thread overview]
Message-ID: <141105085605.ZM2602@torch.brasslantern.com> (raw)
In-Reply-To: <141104200447.ZM1399@torch.brasslantern.com>

In case anyone from Apple is reading this thread ...

} } > http://www.opensource.apple.com/source/zsh/zsh-61/patches/

The svn-zsh-complete.patch is both obsolete and consequently wrong.
It's based on files from 2007-2008 but there was an equivalent and
now conflicting patch in 2011.

} } The only "interesting" patch I can see is the utmpx one 
} 
} Yeah, I'm a bit curious about that one.

This sure looks to me to be redundant with the existing lines

     95 # ifndef ut_name
     96 #  define ut_name ut_user
     97 # endif

which are inside the same #if as the addition in utmpx_ut_user.patch.
I can only guess that there was an older version of that patch and
they simply updated it without checking whether it was still needed.

} } I'm not exactly sure what the arg_zero patch does though.
} 
} Apparently it's somehow possible to invoke the program with argc == 0.
} The call to zerr() eventually goes through zwarning() which passes
} argzero to nicezputs(), so it has to have a value for that to work.

I guess we could pick this one up, though it seems bizarre.


      reply	other threads:[~2014-11-05 16:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01  4:48 Pedro Giffuni
2014-11-01  7:57 ` Mikael Magnusson
2014-11-05  4:04   ` Bart Schaefer
2014-11-05 16:56     ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=141105085605.ZM2602@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).