zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: BUG: failure in "vcs_info prompt" aborts precmd function
Date: Sun, 23 Nov 2014 11:38:57 -0800	[thread overview]
Message-ID: <141123113857.ZM10791@torch.brasslantern.com> (raw)
In-Reply-To: <20141123190201.37536a9f@pws-pc.ntlworld.com>

On Nov 23,  7:02pm, Peter Stephenson wrote:
} Subject: Re: BUG: failure in "vcs_info prompt" aborts precmd function
}
} On Sat, 22 Nov 2014 14:44:00 -0800
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > On the other hand, I don't know WHY $(<notafile) was made a fatal error.
} 
} Looks like most redirection errors are fatal, so from that point of view

Hmm.

torch% () { cat < notafile ; echo got here }
(anon): no such file or directory: notafile
got here

What was fatal about that?  Even with a builtin:

torch% () { read -E < notafile ; echo got here }
(anon): no such file or directory: notafile
got here

Even this:

torch% print =(<notafile)
zsh: no such file or directory: notafile
/tmp/zshd0zlSR

(Aside:

    cat =(<file) >| file

reads the contents into the temp file for =(...) before clobbering it
for the >| redirection.  Probably handy for something.)

} this would be consistent.  However, from the other point of view,
} $(<...) might be thought to be faking up a subshell, in which case it
} probably shouldn't be.  I suppose that just never got discussed before.
} 
} The principle of least surprise perhaps says it doesn't look like it should
} be fatal, therefore it shouldn't be.

Should I commit/push 33775 then?  Anybody object?


  reply	other threads:[~2014-11-23 19:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-22 17:13 Daniel Hahler
2014-11-22 17:20 ` [PATCH] vcs_info: test -f .git/rebase-merge/done before reading it Daniel Hahler
2014-11-22 17:51 ` BUG: failure in "vcs_info prompt" aborts precmd function Mikael Magnusson
2014-11-22 18:01   ` Daniel Hahler
2014-11-22 22:20     ` Mikael Magnusson
2014-11-22 22:44       ` Bart Schaefer
2014-11-23 19:02         ` Peter Stephenson
2014-11-23 19:38           ` Bart Schaefer [this message]
2014-11-23 20:04             ` Peter Stephenson
2014-11-23 15:58       ` Daniel Hahler
2014-11-23 18:08         ` Mikael Magnusson
2014-11-23 19:57           ` TRY_BLOCK_ERROR and exit status Bart Schaefer
2014-11-24 10:11             ` Peter Stephenson
2014-11-25  8:01               ` Bart Schaefer
2014-11-25  9:18                 ` Peter Stephenson
2014-11-23 18:13         ` BUG: failure in "vcs_info prompt" aborts precmd function Bart Schaefer
2014-11-23 18:52           ` Mikael Magnusson
2014-11-23 19:47             ` Bart Schaefer
2014-11-23 22:03           ` Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=141123113857.ZM10791@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).