From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33915-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10844 invoked by alias); 7 Dec 2014 19:58:23 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33915
Received: (qmail 6077 invoked from network); 7 Dec 2014 19:58:22 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=MJ3XQ3dg c=1 sm=1 tr=0	a=FT8er97JFeGWzr5TCOCO5w==:117
 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8	a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10
 a=A92cGCtB03wA:10	a=3lpO-7oa8BybO9o1psIA:9 a=CjuIK1q_8ugA:10 a=IbTMy7x5uRwA:10
	a=5JBNzT4BafwA:10 a=rc86MDUec-IA:10
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <141207115828.ZM23468@torch.brasslantern.com>
Date: Sun, 07 Dec 2014 11:58:28 -0800
In-reply-to: <201412071859.sB7Ix5Xq005917@pws-pc.ntlworld.com>
Comments: In reply to Peter Stephenson <p.w.stephenson@ntlworld.com>
 "Re: Interrupting globs (Re: Something rotten in tar completion)" (Dec  7,
 6:59pm)
References: <201412071859.sB7Ix5Xq005917@pws-pc.ntlworld.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org (Zsh hackers list)
Subject: Re: Interrupting globs (Re: Something rotten in tar completion)
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Dec 7,  6:59pm, Peter Stephenson wrote:
}
} I'm worried about the various occurrences of this:
} 
} 	    /* Keep any user interrupt error status */
} 	    errflag = oef | (errflag & ERRFLAG_INT);

I believe that could be rewritten as

	errflag &= ~ERRFLAG_ERROR;
	errflag |= oef;

to avoid reading errflag and then writing back to it.  That's likely
more efficient than queueing/unqueing signals.