From: Bart Schaefer <schaefer@brasslantern.com>
To: Chirantan Ekbote <chirantan@google.com>, zsh-workers@zsh.org
Subject: Re: Bug in interaction with pid namespaces
Date: Wed, 17 Dec 2014 08:54:35 -0800 [thread overview]
Message-ID: <141217085435.ZM545@torch.brasslantern.com> (raw)
In-Reply-To: <CAJFHJroSdbbEtkYgdwa6mF4n7MQ4WAuJkLsNO_oDQF4-kwJTCw@mail.gmail.com>
On Dec 16, 11:50pm, Chirantan Ekbote wrote:
}
} We're not trying to use zsh as a replacement for init. I first noticed
} this issue because the chrome os build system recently switched to
} using pid namespaces in the build chroot. [...] In the actual workflow
} where this is an issue for me, the pid is somewhere in the 240 to 270
} range and zsh is only meant to behave like a regular shell.
OK, so the issue is that zsh is started as a (possibly indirect) child
of whatever was given "leadership" of the namespace, but at the time
zsh starts GETPGRP() == 0.
That sounds like a bug in one of the ancestor processes, then, because
shouldn't whatever *that* is, have become a group leader, or assigned
the process group to the fork() pid before execve() of zsh?
} > } - if ((mypgrp = GETPGRP()) > 0) {
} > } + if ((mypgrp = GETPGRP()) >= 0) {
} >
} > I don't see any reason not to make that change ...
} >
}
} Excellent. Should I re-send it as a proper patch?
No need, I already applied it and pushed it to the repository.
} So the problem is that on exit zsh gives a warning:
}
} zsh: can't set tty pgrp: no such process
}
} which I thought was due to the call to setpgrp() but is actually in
} the call to attachtty().
Aha. That means that one of
tcsetpgrp(SHTTY, pgrp)
or
arg = &pgrp
ioctl(SHTTY, TIOCSPGRP, &arg)
is returning -1 and errno == ESRCH. Which makes sense if pgrp == 0.
But that also means that zsh is being invoked as an interactive shell,
because attachtty() is a no-op otherwise. I can't imagine why the
chrome os build would need to run an interactive shell.
However, I suggest the following. The mypgrp = origpgrp assignment is
questionable because the pgrp won't actually have been changed, but it
may help elsewhere in tests that mypgrp != GETPGRP(). Shell exit is
not the only place where release_pgrp() is called.
diff --git a/Src/jobs.c b/Src/jobs.c
index 8c4254a..c6e1bce 100644
--- a/Src/jobs.c
+++ b/Src/jobs.c
@@ -2779,8 +2779,11 @@ void
release_pgrp(void)
{
if (origpgrp != mypgrp) {
- attachtty(origpgrp);
- setpgrp(0, origpgrp);
+ /* in linux pid namespaces, origpgrp may never have been set */
+ if (origpgrp) {
+ attachtty(origpgrp);
+ setpgrp(0, origpgrp);
+ }
mypgrp = origpgrp;
}
}
next prev parent reply other threads:[~2014-12-17 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:07 Chirantan Ekbote
2014-12-17 6:27 ` Bart Schaefer
2014-12-17 7:50 ` Chirantan Ekbote
2014-12-17 16:54 ` Bart Schaefer [this message]
2014-12-17 22:52 ` Chirantan Ekbote
2014-12-17 7:32 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141217085435.ZM545@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=chirantan@google.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).