From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34048-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 24886 invoked by alias); 23 Dec 2014 02:06:53 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34048
Received: (qmail 27837 invoked from network); 23 Dec 2014 02:06:51 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=PYxIXZlY c=1 sm=1 tr=0	a=FT8er97JFeGWzr5TCOCO5w==:117
 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8	a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10
 a=A92cGCtB03wA:10	a=9arrhYx6wJyDWSzbn_cA:9 a=CjuIK1q_8ugA:10
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <141222180718.ZM7093@torch.brasslantern.com>
Date: Mon, 22 Dec 2014 18:07:18 -0800
In-reply-to:
 <CAHYJk3SuwsxGG22+xEV7D9vh_zFOMSrXXCh_Xvg8P_DqxSAfMg@mail.gmail.com>
Comments: In reply to Mikael Magnusson <mikachu@gmail.com>
 "Re: Insecure tempfile creation" (Dec 22, 11:01pm)
References: <20141222203624.GA24855@tarsus.local2>
	<CAHYJk3SuwsxGG22+xEV7D9vh_zFOMSrXXCh_Xvg8P_DqxSAfMg@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: Insecure tempfile creation
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Dec 22, 11:01pm, Mikael Magnusson wrote:
}
} Your first patch is not the best version of that solution;
} 
} +() {
} +  ${=${VISUAL:-${EDITOR:-vi}}} $1
} +  BUFFER="$(<$1)"
} +} =(print -R "$PREBUFFER$BUFFER")

Even that isn't the best formulation, =(<<<"$PREBUFFER$BUFFER") would
avoid forking the print.

} I don't know what the exec </dev/tty is for, but it can be added back
} if it's needed. I've used this patch for two years and never noticed
} any problems though.

Widgets run with stdin closed, so if the chosen editor doesn't open the
tty or one of the other std*s directly, it breaks without </dev/tty.