From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17665 invoked by alias); 6 Jan 2015 05:34:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34113 Received: (qmail 25745 invoked from network); 6 Jan 2015 05:34:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=qulcKpXzH3vNUrOiJFjcmfXsxmfJuu43XbDQ2nw6TrA=; b=vrLedmC9IOcV2g8ABQ0NLSTVYnCyZIaSGooeLoza8M64kZ7b0X3dU+STJ5OlIMS0gs 810YBqQiZgVuvv1TbuEBGoteKVYKN2gAyE2z3sYvKHnM23F6aIRBIM2yWX8H7jFQ7b1r yCqNMiENhWDATrx4yUhHidqNdBwMR2CFaaDnOA8hZ1Wl+P26JxMF5an+pmysA8eLMgc+ ChPvFL1AJqy8xpckDXiaoJkhGsKoOVDzOpxFuHTQVMMvVq4gbu1naUhz0chRCzVBB9HK i4fg3ESyGHLfq7Uk8bqOJfV4bdQCQvk5s/xqhrqN9XkYveKYMOg0zOqUzVP8LmhMaqF7 ybBg== X-Received: by 10.180.84.98 with SMTP id x2mr32548155wiy.14.1420521977240; Mon, 05 Jan 2015 21:26:17 -0800 (PST) From: Mikael Magnusson To: zsh-workers@zsh.org Subject: PATCH 10/17: whence: use dupstring to not leak memory Date: Tue, 6 Jan 2015 06:25:42 +0100 Message-Id: <1420521949-30483-11-git-send-email-mikachu@gmail.com> X-Mailer: git-send-email 2.2.0.GIT In-Reply-To: <1420521949-30483-1-git-send-email-mikachu@gmail.com> References: <1420521949-30483-1-git-send-email-mikachu@gmail.com> All other assignments to buf use the heap, and it's never freed. Found by Coverity (Issue 1255786). --- Src/builtin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src/builtin.c b/Src/builtin.c index 2b9c4de..ae7f53b 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -3322,7 +3322,7 @@ bin_whence(char *nam, char **argv, Options ops, int func) for (pp = path; *pp; pp++) { if (**pp) { buf = zhtricat(*pp, "/", *argv); - } else buf = ztrdup(*argv); + } else buf = dupstring(*argv); if (iscom(buf)) { if (wd) { -- 2.2.0.GIT