From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15961 invoked by alias); 6 Jan 2015 05:32:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34112 Received: (qmail 14802 invoked from network); 6 Jan 2015 05:32:55 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=JeRO321K/h+FFskdTGPfDMAB/Qa5uI0C1fkjfVxMdBE=; b=cqygHrNBOXv/fLdY+UitHarwDXE1eOb2FomzXJJYdM3FfvA7gVrQrLheQVemEss/QN zGlyg2NjuXaA1YcqDX7CoMbxHtNrHWGdDSXLGoME31qAvHSgiSav+n2Y1TISpm4egvII 6fz8Ll7aJKcKJ3B23gbU/IPZTL5hXnOvGTzSgwQVAoL1pk/Dmyi6FroQxq44Pfd8otq6 l+vX3KuK+/Gy2XrkxRpGeIl+BXdHFy/TbU9RuAV8jM2sCxGTO4F7lq+eiopZNntnc1Wy kf1FK2eMO8MpAfgfY4HkChqk6cwPC+DVmmskF068WiU8rRa2bayl+QT8WK25+9FVmqra Fv9w== X-Received: by 10.194.95.10 with SMTP id dg10mr188502057wjb.82.1420521979481; Mon, 05 Jan 2015 21:26:19 -0800 (PST) From: Mikael Magnusson To: zsh-workers@zsh.org Subject: PATCH 12/17: typeset: fix leak of oldval Date: Tue, 6 Jan 2015 06:25:44 +0100 Message-Id: <1420521949-30483-13-git-send-email-mikachu@gmail.com> X-Mailer: git-send-email 2.2.0.GIT In-Reply-To: <1420521949-30483-1-git-send-email-mikachu@gmail.com> References: <1420521949-30483-1-git-send-email-mikachu@gmail.com> Found by Coverity (Issue 1255803). --- Src/builtin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Src/builtin.c b/Src/builtin.c index ae7f53b..38d34ae 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -2510,6 +2510,8 @@ bin_typeset(char *name, char **argv, Options ops, int func) asg->name), func, (on | PM_ARRAY) & ~PM_EXPORTED, off, roff, asg->value, NULL, ops, 0))) { + if (oldval) + zsfree(oldval); unqueue_signals(); return 1; } -- 2.2.0.GIT