From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22618 invoked by alias); 6 Jan 2015 06:21:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34120 Received: (qmail 14860 invoked from network); 6 Jan 2015 06:21:31 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=XSvYHU2STL42/vQliQcD2Xr5JjUfKx0KAylRfrP+T4w=; b=WVgb/Gq1C6I6NjwBkzMv6VZjBEqdFGqQ7xAXC2g+fg5T3PVFpgdIRBMnJzY7aXwPMb 3j14LVZfTjiNlk7F5lgeN21Od0ZdleOxwUq7jiyTel1oaHlsSOgOxlZgEkgtEJeKOBR3 Ebz4BCj0hiTZ4ThMdHQwrMVeXy2wUZyF4E0uB1Z9c0Aixy/2FXfvFr/0sZR1B/A4yJ1u kRtL6b9rU3AInJ8lxIGOqSYQVc2Y8MSHsXZ8qlKPFFzVK83pv2wCZyRAl7NHtB3P6l7O UFwUwn1/mlmgIIUK8YfEDroaj9DbyJxBQOwhPyDo+X49/nBv7gqVlrh3Tvz+BU0NZooA vLcQ== X-Received: by 10.194.92.116 with SMTP id cl20mr191105062wjb.71.1420521984277; Mon, 05 Jan 2015 21:26:24 -0800 (PST) From: Mikael Magnusson To: zsh-workers@zsh.org Subject: PATCH 16/17: compctl: Comparing array with 0 does nothing, check contents (should it be dropped instead?) Date: Tue, 6 Jan 2015 06:25:48 +0100 Message-Id: <1420521949-30483-17-git-send-email-mikachu@gmail.com> X-Mailer: git-send-email 2.2.0.GIT In-Reply-To: <1420521949-30483-1-git-send-email-mikachu@gmail.com> References: <1420521949-30483-1-git-send-email-mikachu@gmail.com> Found by Coverity (Issue 1255780). --- Src/Zle/compctl.c | 2 +- Src/jobs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Src/Zle/compctl.c b/Src/Zle/compctl.c index 96ad6a2..2a80e6c 100644 --- a/Src/Zle/compctl.c +++ b/Src/Zle/compctl.c @@ -3685,7 +3685,7 @@ makecomplistflags(Compctl cc, char *s, int incmd, int compadd) for (i = 0; i <= maxjob; i++) if ((jobtab[i].stat & STAT_INUSE) && - jobtab[i].procs && jobtab[i].procs->text) { + jobtab[i].procs && jobtab[i].procs->text[0]) { int stopped = jobtab[i].stat & STAT_STOPPED; j = dupstring(jobtab[i].procs->text); diff --git a/Src/jobs.c b/Src/jobs.c index c6e1bce..295f4c9 100644 --- a/Src/jobs.c +++ b/Src/jobs.c @@ -2718,7 +2718,7 @@ findjobnam(const char *s) for (jobnum = maxjob; jobnum >= 0; jobnum--) if (!(jobtab[jobnum].stat & (STAT_SUBJOB | STAT_NOPRINT)) && jobtab[jobnum].stat && jobtab[jobnum].procs && jobnum != thisjob && - jobtab[jobnum].procs->text && strpfx(s, jobtab[jobnum].procs->text)) + jobtab[jobnum].procs->text[0] && strpfx(s, jobtab[jobnum].procs->text)) return jobnum; return -1; } -- 2.2.0.GIT