From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5218 invoked by alias); 6 Jan 2015 05:56:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34118 Received: (qmail 6442 invoked from network); 6 Jan 2015 05:56:09 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=bvmLK5BdEAWBI8wL1dXcbKmOtmIo48qswkRywF6ubAI=; b=DoZ9x6DnAJEwcorPHfPHAECmKJM3GPW0ydaXZ5g/z8rM5P7RDpPm7Yl19ruomuV6ua bHg782LQAx1hcrpd4XaxxJTutenVdPlyBLq8BezX72HR7vkeRo3MEjLAxBXTvZT8lWV4 3qAFythpQOuauvSW8G+173nyvcFAWh8SHW/rq7rQj6L+NdUnBU1OKjpiWqz8wj1INp2r m4uk9VyWJY3fiuoo/QqVIH+A0nDNdosev/ULlFTxJ59PzrBvhmJxKKYlc6a1ro/iBvZA NX9IZP2nSGvw2UPwXRWxJjgDmXkVOBvi8N5HZ1SIo+zyhRHHxOpXfDDmX9WTx33rj3H1 R3UA== X-Received: by 10.194.61.18 with SMTP id l18mr188928233wjr.42.1420521967916; Mon, 05 Jan 2015 21:26:07 -0800 (PST) From: Mikael Magnusson To: zsh-workers@zsh.org Subject: PATCH 02/17: Don't crash when writing out history if HOST is unset Date: Tue, 6 Jan 2015 06:25:34 +0100 Message-Id: <1420521949-30483-3-git-send-email-mikachu@gmail.com> X-Mailer: git-send-email 2.2.0.GIT In-Reply-To: <1420521949-30483-1-git-send-email-mikachu@gmail.com> References: <1420521949-30483-1-git-send-email-mikachu@gmail.com> Found by Coverity (Issue 1255793). --- Src/hist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Src/hist.c b/Src/hist.c index a006170..8ff9eff 100644 --- a/Src/hist.c +++ b/Src/hist.c @@ -2801,7 +2801,8 @@ lockhistfile(char *fn, int keep_trying) #ifdef HAVE_LINK # ifdef HAVE_SYMLINK sprintf(pidbuf, "/pid-%ld/host-", (long)mypid); - lnk = bicat(pidbuf, getsparam("HOST")); + lnk = getsparam("HOST"); + lnk = bicat(pidbuf, lnk ? lnk : ""); /* We'll abuse fd as our success flag. */ while ((fd = symlink(lnk, lockfile)) < 0) { if (errno != EEXIST) { -- 2.2.0.GIT