From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8509 invoked by alias); 6 Jan 2015 05:26:16 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34104 Received: (qmail 8094 invoked from network); 6 Jan 2015 05:26:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=Es7v9ZKxtB4kATEX0CCWLNgzjW3m4Q1+acJbrwvVD6U=; b=oshMhzRdMNlLocN7uy49FpdMLQHwNlCFd0iW7dIR8st1TxZ+YQY6T5eiFsGlQPild7 EZnAR9f6MQytTa65WBG7BNaRB0G7riDWlTRDnBrOgNUs+DcR/YacCw3PUN9DGcoQq8JV KFpBy+uqhGi2PPAUgvjGTF2povk3lNkad8ARNLI15nbFDKaZSZq6zXMeWHgwIzyrEX1G 4lAN8N2m0WHloEz4L7mhrzvEHtfm9SMYLt/KXNMKvzswkuN3sEPqWo0bZ6dcYjGa+9Ld 2w40jwjxyzbIn+cly5xvdd5ORa/r0s2pzTGrcr7M/AHQvwVJQO2Ts3NFgq12LSEj/sZ1 fzaw== X-Received: by 10.180.228.72 with SMTP id sg8mr33287824wic.48.1420521972535; Mon, 05 Jan 2015 21:26:12 -0800 (PST) From: Mikael Magnusson To: zsh-workers@zsh.org Subject: PATCH 06/17: compctl: Remove pointless check Date: Tue, 6 Jan 2015 06:25:38 +0100 Message-Id: <1420521949-30483-7-git-send-email-mikachu@gmail.com> X-Mailer: git-send-email 2.2.0.GIT In-Reply-To: <1420521949-30483-1-git-send-email-mikachu@gmail.com> References: <1420521949-30483-1-git-send-email-mikachu@gmail.com> cc has already been derefed a bunch of times leading up to here. Found by Coverity (Issue 1255841). --- Src/Zle/compctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src/Zle/compctl.c b/Src/Zle/compctl.c index d15c2d1..96ad6a2 100644 --- a/Src/Zle/compctl.c +++ b/Src/Zle/compctl.c @@ -1515,7 +1515,7 @@ printcompctl(char *s, Compctl cc, int printflags, int ispat) if (cclist & COMP_LIST) printf(" --"); } - if (cc && cc->xor) { + if (cc->xor) { /* print xor'd (+) completions */ printf(" +"); if (cc->xor != &cc_default) -- 2.2.0.GIT