From: Mikael Magnusson <mikachu@gmail.com>
To: zsh-workers@zsh.org
Subject: PATCH: Handle NULL return from dlerror() more gracefully
Date: Sun, 25 Jan 2015 18:32:10 +0100 [thread overview]
Message-ID: <1422207130-24907-1-git-send-email-mikachu@gmail.com> (raw)
Found by Daniel Hahler on irc,
<blueyed> > module_path=() ; zmodload -F zsh/stat b:zstat
<SweetieBot> blueyed: zsh[239]: segfault at 0 ip 080be250 sp bfe11d20 error 4 in zsh[8048000+95000]
---
Src/module.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Src/module.c b/Src/module.c
index 616207e..e78bd82 100644
--- a/Src/module.c
+++ b/Src/module.c
@@ -1596,8 +1596,9 @@ do_load_module(char const *name, int silent)
ret = try_load_module(name);
if (!ret && !silent) {
#ifdef HAVE_DLERROR
+ char *errstr = dlerror();
zwarn("failed to load module `%s': %s", name,
- metafy(dlerror(), -1, META_USEHEAP));
+ errstr ? metafy(errstr, -1, META_USEHEAP) : "empty module path");
#else
zwarn("failed to load module: %s", name);
#endif
--
2.2.0.GIT
reply other threads:[~2015-01-25 17:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422207130-24907-1-git-send-email-mikachu@gmail.com \
--to=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).