zsh-workers
 help / color / mirror / code / Atom feed
From: Heiko Becker <heirecka@exherbo.org>
To: zsh-workers@zsh.org
Subject: [PATCH] Use CC to determine if gcc is used
Date: Sun, 26 Apr 2015 19:48:31 +0200	[thread overview]
Message-ID: <1430070511-9895-1-git-send-email-heirecka@exherbo.org> (raw)

I ran into this with gcc-5.1 and CPP set to x86_64-pc-linux-gnu-cpp
which isn't catched by the intended case branch and caused zsh to be
miscompiled in the process.
---
 Src/zsh.mdd | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Src/zsh.mdd b/Src/zsh.mdd
index 71dd613..3c8c355 100644
--- a/Src/zsh.mdd
+++ b/Src/zsh.mdd
@@ -28,8 +28,8 @@ hdrdeps="zshcurses.h zshterm.h"
 # on the option to remove them being the same.
 signames.c: signames1.awk signames2.awk ../config.h @SIGNAL_H@
 	$(AWK) -f $(sdir)/signames1.awk @SIGNAL_H@ >sigtmp.c
-	case "$(CPP)" in \
-	gcc*) \
+	case "$(CC)" in \
+	*gcc*) \
 	$(CPP) -P sigtmp.c >sigtmp.out;; \
 	*) \
 	$(CPP) sigtmp.c >sigtmp.out;; \
-- 
2.3.3


             reply	other threads:[~2015-04-26 17:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26 17:48 Heiko Becker [this message]
2015-04-27  8:47 ` Peter Stephenson
2015-04-27  9:07   ` Peter Stephenson
2015-04-27 13:30     ` Daniel Shahaf
2015-04-27 14:11       ` Peter Stephenson
2015-04-27 16:37         ` Heiko Becker
2015-04-27 16:50           ` Peter Stephenson
2015-04-27 16:57             ` Heiko Becker
2015-04-27 17:09               ` Peter Stephenson
2015-04-27 17:26                 ` Heiko Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430070511-9895-1-git-send-email-heirecka@exherbo.org \
    --to=heirecka@exherbo.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).