From: Kamil Dudka <kdudka@redhat.com>
To: zsh-workers@zsh.org
Subject: [PATCH] mkenvstr: avoid crash in case NULL is given as value
Date: Tue, 19 May 2015 20:24:14 +0200 [thread overview]
Message-ID: <1432059854-2109-1-git-send-email-kdudka@redhat.com> (raw)
The crash happens while running a syntax check in ksh emulation mode:
ln -s /bin/zsh ksh
echo > script.sh
./ksh -n script.sh
Originally reported at <https://bugzilla.redhat.com/1222867>.
---
Src/params.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Src/params.c b/Src/params.c
index 045ac1e..1df97c6 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -4582,6 +4582,8 @@ mkenvstr(char *name, char *value, int flags)
{
char *str, *s;
int len_name, len_value;
+ if (!value)
+ return NULL;
len_name = strlen(name);
for (len_value = 0, s = value;
--
2.4.1
next reply other threads:[~2015-05-19 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 18:24 Kamil Dudka [this message]
2015-05-19 23:12 ` Bart Schaefer
2015-05-20 14:43 ` Kamil Dudka
2015-05-20 17:23 ` Bart Schaefer
2015-05-20 17:35 ` Kamil Dudka
2015-05-20 18:17 ` Kamil Dudka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432059854-2109-1-git-send-email-kdudka@redhat.com \
--to=kdudka@redhat.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).