From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2590 invoked by alias); 19 May 2015 18:24:31 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35223 Received: (qmail 20896 invoked from network); 19 May 2015 18:24:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.0 From: Kamil Dudka To: zsh-workers@zsh.org Subject: [PATCH] mkenvstr: avoid crash in case NULL is given as value Date: Tue, 19 May 2015 20:24:14 +0200 Message-Id: <1432059854-2109-1-git-send-email-kdudka@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 The crash happens while running a syntax check in ksh emulation mode: ln -s /bin/zsh ksh echo > script.sh ./ksh -n script.sh Originally reported at . --- Src/params.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Src/params.c b/Src/params.c index 045ac1e..1df97c6 100644 --- a/Src/params.c +++ b/Src/params.c @@ -4582,6 +4582,8 @@ mkenvstr(char *name, char *value, int flags) { char *str, *s; int len_name, len_value; + if (!value) + return NULL; len_name = strlen(name); for (len_value = 0, s = value; -- 2.4.1