From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27579 invoked by alias); 12 Aug 2015 09:36:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36123 Received: (qmail 1970 invoked from network); 12 Aug 2015 09:36:32 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=X4+4GuL7bCyX6vN/VXLHOeTs74K9uJDGUtIDx1xnXgw=; b=l9aK2HxHMWla0OdLx/9cvCX3Q1hZJDwW4XBSnSn+r1mG64xjSn5sJ8c83YiG9WpcNl 35HLwrIiM56MCSttYI+I/IYlnH9EEWZ6O22wgCkJkt/ajYtS+JUdeJfhlpuMhL9x6HaT CSrOPe3miOBNnNjDnIzggdKxavzd/ouqV61jto/bY5FH7/PTcE7dJq+3CPeSkOTqB4Qp BFTiawN7/PgJbz45oPIYkE9Pqp+l2rccpodrF0VBAxxoHxe3BIuzGhqD/PrF+MoslwDc 92w/Z4DyluOwgCb7b1Q4bc7rViXqxgRYbxVt/w8WzjHtnCfU9JJWEkEl9U580HdsYoV7 gyXg== X-Received: by 10.180.20.48 with SMTP id k16mr46804945wie.56.1439372189109; Wed, 12 Aug 2015 02:36:29 -0700 (PDT) From: Wieland Hoffmann To: zsh-workers@zsh.org Cc: Wieland Hoffmann Subject: [PATCH] _git: Quote the return value of __git_committish_range{first,last} Date: Wed, 12 Aug 2015 11:36:17 +0200 Message-Id: <1439372177-32218-1-git-send-email-themineo@gmail.com> X-Mailer: git-send-email 2.5.0 Otherwise, __git_is_committish_range performs word splitting if it's passed a range that includes spaces (like "master@{1 week ago}..master"). --- Completion/Unix/Command/_git | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index 5b78a2b..f5dbbae 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -4973,8 +4973,8 @@ __git_is_treeish () { (( $+functions[__git_is_committish_range] )) || __git_is_committish_range () { [[ $1 == *..(.|)* ]] || return 1 - local first=$(__git_committish_range_first $1) - local last=$(__git_committish_range_last $1) + local first="$(__git_committish_range_first $1)" + local last="$(__git_committish_range_last $1)" [[ $first != *..* && $last != *..* ]] && \ __git_is_committish $first && \ __git_is_committish $last -- 2.5.0