* [PATCH] Fix broken VCS_Info in 5.7
@ 2019-01-26 20:42 dana
0 siblings, 0 replies; only message in thread
From: dana @ 2019-01-26 20:42 UTC (permalink / raw)
To: Zsh workers
A bunch of Arch users are reporting that VCS_Info is broken:
https://bugs.archlinux.org/task/61533
To replicate it you just need to run vcs_info outside of a repo:
% zsh -f
% autoload -Uz vcs_info
% vcs_info
VCS_INFO_detect_p4:79: maximum nested function level reached; increase FUNCNEST?
This is apparently due to workers/43618, which introduced a function-def guard
to a function that wants to redefine itself. Just taking that back out seems
to fix it.
Wish they'd mentioned it to #zsh an hour or two ago :(
dana
diff --git a/Functions/VCS_Info/Backends/VCS_INFO_detect_p4 b/Functions/VCS_Info/Backends/VCS_INFO_detect_p4
index d171c68ee..5ec21da9f 100644
--- a/Functions/VCS_Info/Backends/VCS_INFO_detect_p4
+++ b/Functions/VCS_Info/Backends/VCS_INFO_detect_p4
@@ -44,7 +44,6 @@ VCS_INFO_p4_get_server() {
}
-(( ${+functions[VCS_INFO_detect_p4]} )) ||
VCS_INFO_detect_p4() {
local serverport p4where
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-26 20:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-26 20:42 [PATCH] Fix broken VCS_Info in 5.7 dana
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).